aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Merry <alex.merry@kde.org>2014-03-21 18:09:13 +0000
committerAlex Merry <alex.merry@kde.org>2014-03-24 11:22:36 +0000
commit2cb32b4dc0ed9aed3ae705d34269f99d82c3c6dc (patch)
tree1f75e31da126844a82464bb2552947220fb3f811
parent16348884c6b3632b9a7c7fee76c74d708c142f38 (diff)
downloadkconfig-2cb32b4dc0ed9aed3ae705d34269f99d82c3c6dc.tar.gz
kconfig-2cb32b4dc0ed9aed3ae705d34269f99d82c3c6dc.tar.bz2
Remove unhelpful comments
These lines of code do not really require any justification. REVIEW: 116962
-rw-r--r--src/kconf_update/kconf_update.cpp2
-rw-r--r--src/kconfig_compiler/CMakeLists.txt2
2 files changed, 0 insertions, 4 deletions
diff --git a/src/kconf_update/kconf_update.cpp b/src/kconf_update/kconf_update.cpp
index f8ba16d1..1af26566 100644
--- a/src/kconf_update/kconf_update.cpp
+++ b/src/kconf_update/kconf_update.cpp
@@ -740,8 +740,6 @@ void KonfUpdate::gotScript(const QString &_script)
QString path = QStandardPaths::locate(QStandardPaths::GenericDataLocation, "kconf_update/" + script);
if (path.isEmpty()) {
if (interpreter.isEmpty()) {
- // KDE4: this was looking into locate("lib", "kconf_update_bin/"). But QStandardPaths doesn't know the lib dirs.
- // Let's look in the install prefix and in PATH.
path = CMAKE_INSTALL_PREFIX "/" LIB_INSTALL_DIR "/kconf_update_bin/" + script;
if (QFile::exists(path)) {
path = QStandardPaths::findExecutable(script);
diff --git a/src/kconfig_compiler/CMakeLists.txt b/src/kconfig_compiler/CMakeLists.txt
index 71f2609d..1fbb4824 100644
--- a/src/kconfig_compiler/CMakeLists.txt
+++ b/src/kconfig_compiler/CMakeLists.txt
@@ -10,6 +10,4 @@ find_package(Qt5Xml 5.2.0 REQUIRED NO_MODULE)
target_link_libraries(kconfig_compiler_kf5 Qt5::Xml)
-# "export" this target too so we can use the LOCATION property of the imported target in
-# FindKDE4Internal.cmake to get the full path to the installed executable instead of using FIND_PROGRAM(), Alex
install(TARGETS kconfig_compiler_kf5 EXPORT KF5ConfigTargets ${INSTALL_TARGETS_DEFAULT_ARGS} )