1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
|
/*
SPDX-FileCopyrightText: 2006 David Faure <faure@kde.org>
SPDX-License-Identifier: LGPL-2.0-only
*/
#include "kdesktopfiletest.h"
#include "helper.h"
#include <kconfiggroup.h>
#include <ksharedconfig.h>
#include <qtemporaryfile.h>
#include "kdesktopfile.h"
#include <QTest>
#if defined(Q_OS_UNIX)
#include <unistd.h>
#endif
QTEST_MAIN(KDesktopFileTest)
void KDesktopFileTest::initTestCase()
{
QStandardPaths::setTestModeEnabled(true);
KConfigGroup actionRestrictions(KSharedConfig::openConfig(), "KDE Action Restrictions");
actionRestrictions.writeEntry("someBlockedAction", false);
}
void KDesktopFileTest::testRead()
{
QTemporaryFile file(QStringLiteral("testReadXXXXXX.desktop"));
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"Type= Application\n"
"Name=My Application\n"
"Icon = foo\n"
"MimeType =text/plain;image/png;\n"
"\n";
file.close();
QVERIFY(QFile::exists(fileName));
QVERIFY(KDesktopFile::isDesktopFile(fileName));
KDesktopFile df(fileName);
QCOMPARE(df.readType(), QString::fromLatin1("Application"));
QVERIFY(df.hasApplicationType());
QCOMPARE(df.readName(), QString::fromLatin1("My Application"));
QCOMPARE(df.readIcon(), QString::fromLatin1("foo"));
QCOMPARE(df.readMimeTypes(), QStringList() << QString::fromLatin1("text/plain") << QString::fromLatin1("image/png"));
QVERIFY(!df.hasLinkType());
QCOMPARE(df.fileName(), QFileInfo(fileName).canonicalFilePath());
}
#if KCONFIGCORE_ENABLE_DEPRECATED_SINCE(5, 0)
void KDesktopFileTest::testReadDirectory()
{
QTemporaryFile file(QStringLiteral("testReadDirectoryXXXXXX.directory"));
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"Type=Directory\n"
"SortOrder=2.desktop;1.desktop;\n"
"\n";
file.close();
QVERIFY(QFile::exists(fileName));
KDesktopFile df(fileName);
QCOMPARE(df.readType(), QString::fromLatin1("Directory"));
QCOMPARE(df.sortOrder(), QStringList() << QString::fromLatin1("2.desktop") << QString::fromLatin1("1.desktop"));
}
#endif
void KDesktopFileTest::testReadLocalized_data()
{
QTest::addColumn<QLocale>("locale");
QTest::addColumn<QString>("translation");
const QString german = QStringLiteral("Meine Anwendung");
const QString swiss = QStringLiteral("Mein Anwendungsli");
QTest::newRow("de") << QLocale(QLocale::German) << german;
QTest::newRow("de_DE") << QLocale(QStringLiteral("de_DE")) << german;
QTest::newRow("de_DE@bayern") << QLocale(QStringLiteral("de_DE@bayern")) << german;
QTest::newRow("de@bayern") << QLocale(QStringLiteral("de@bayern")) << german;
QTest::newRow("de@freiburg") << QLocale(QStringLiteral("de@freiburg")) << QStringLiteral("Mein Anwendungsle");
// For CH we have a special translation
QTest::newRow("de_CH") << QLocale(QLocale::German, QLocale::Switzerland) << swiss;
QTest::newRow("de_CH@bern") << QLocale(QStringLiteral("de_CH@bern")) << swiss;
// Austria should fall back to "de"
QTest::newRow("de_AT") << QLocale(QLocale::German, QLocale::Austria) << german;
QTest::newRow("de_AT@tirol") << QLocale(QStringLiteral("de_AT@tirol")) << german;
// no translation for French
QTest::newRow("fr") << QLocale(QLocale::French) << QStringLiteral("My Application");
}
void KDesktopFileTest::testReadLocalized()
{
QTemporaryFile file(QStringLiteral("testReadLocalizedXXXXXX.desktop"));
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"Type=Application\n"
"Name=My Application\n"
"Name[de]=Meine Anwendung\n"
"Name[de@freiburg]=Mein Anwendungsle\n"
"Name[de_CH]=Mein Anwendungsli\n"
"Icon=foo\n"
"\n";
file.close();
QVERIFY(QFile::exists(fileName));
QVERIFY(KDesktopFile::isDesktopFile(fileName));
DefaultLocale defaultLocale;
QFETCH(QLocale, locale);
QLocale::setDefault(locale);
KDesktopFile df(fileName);
QEXPECT_FAIL("de@freiburg", "QLocale doesn't support modifiers", Continue);
QTEST(df.readName(), "translation");
}
void KDesktopFileTest::testSuccessfulTryExec()
{
QTemporaryFile file;
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"TryExec=whoami\n"
"\n";
file.close();
QVERIFY(QFile::exists(fileName));
KDesktopFile df(fileName);
QCOMPARE(df.tryExec(), true);
}
void KDesktopFileTest::testUnsuccessfulTryExec()
{
QTemporaryFile file;
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"TryExec=/does/not/exist\n"
"\n";
file.close();
QVERIFY(QFile::exists(fileName));
KDesktopFile df(fileName);
QCOMPARE(df.tryExec(), false);
}
void KDesktopFileTest::testActionGroup()
{
QTemporaryFile file;
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
// make sure escaping of ';' using "\;" works
"Actions=encrypt;semi\\;colon;decrypt;\n"
"[Desktop Action encrypt]\n"
"Name=Encrypt file\n"
"[Desktop Action decrypt]\n"
"Name=Decrypt file\n"
// no escaping needed in group header
"[Desktop Action semi;colon]\n"
"Name=With semicolon\n"
"\n";
file.close();
QVERIFY(QFile::exists(fileName));
KDesktopFile df(fileName);
QCOMPARE(df.readType(), QString());
QCOMPARE(df.fileName(), QFileInfo(fileName).canonicalFilePath());
QCOMPARE(df.readActions(), (QStringList{QStringLiteral("encrypt"), QStringLiteral("semi;colon"), QStringLiteral("decrypt")}));
QCOMPARE(df.hasActionGroup(QStringLiteral("encrypt")), true);
QCOMPARE(df.hasActionGroup(QStringLiteral("semi;colon")), true);
QCOMPARE(df.hasActionGroup(QStringLiteral("decrypt")), true);
QCOMPARE(df.hasActionGroup(QStringLiteral("doesnotexist")), false);
KConfigGroup cg = df.actionGroup(QStringLiteral("encrypt"));
QVERIFY(cg.hasKey("Name"));
QCOMPARE(cg.readEntry("Name"), QStringLiteral("Encrypt file"));
cg = df.actionGroup(QStringLiteral("decrypt"));
QVERIFY(cg.hasKey("Name"));
QCOMPARE(cg.readEntry("Name"), QStringLiteral("Decrypt file"));
cg = df.actionGroup(QStringLiteral("semi;colon"));
QVERIFY(cg.hasKey("Name"));
QCOMPARE(cg.readEntry("Name"), QStringLiteral("With semicolon"));
}
void KDesktopFileTest::testIsAuthorizedDesktopFile()
{
QTemporaryFile file(QStringLiteral("testAuthXXXXXX.desktop"));
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"Type=Application\n"
"Name=My Application\n"
"Exec=kfoo\n"
"\n";
file.close();
QVERIFY(QFile::exists(fileName));
#if defined(Q_OS_UNIX)
// Try to fix test failing in docker running as root
const QFileInfo entryInfo(fileName);
if (entryInfo.ownerId() == 0) {
// try to find a valid user/group combination
for (int i = 1; i < 100; ++i) {
if (chown(fileName.toLocal8Bit().constData(), i, i) == 0) {
break;
}
}
const QFileInfo entryInfo1(fileName);
if (entryInfo1.ownerId() == 0) {
QEXPECT_FAIL("", "Running test as root and could not find a non root user to change the ownership of the file too", Continue);
}
}
#endif
QVERIFY(!KDesktopFile::isAuthorizedDesktopFile(fileName));
const QString installedFile = QStandardPaths::locate(QStandardPaths::GenericDataLocation, QStringLiteral("/kservices5/http_cache_cleaner.desktop"));
if (!installedFile.isEmpty()) {
QVERIFY(KDesktopFile::isAuthorizedDesktopFile(installedFile));
} else {
qWarning("Skipping test for http_cache_cleaner.desktop, not found. kio not installed?");
}
const QString autostartFile = QStandardPaths::locate(QStandardPaths::GenericConfigLocation, QStringLiteral("autostart/plasma-desktop.desktop"));
if (!autostartFile.isEmpty()) {
QVERIFY(KDesktopFile::isAuthorizedDesktopFile(autostartFile));
} else {
qWarning("Skipping test for plasma-desktop.desktop, not found. kde-workspace not installed?");
}
}
void KDesktopFileTest::testTryExecWithAuthorizeAction()
{
{
QTemporaryFile file(QStringLiteral("testAuthActionXXXXXX.desktop"));
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"Type=Application\n"
"Name=My Application\n"
"Exec=kfoo\n"
"TryExec=";
#ifdef Q_OS_WIN
ts << "cmd\n";
#else
ts << "bash\n";
#endif
ts << "X-KDE-AuthorizeAction=someAction"
"\n";
file.close();
KDesktopFile desktopFile(fileName);
QVERIFY(desktopFile.tryExec());
}
{
QTemporaryFile file(QStringLiteral("testAuthActionXXXXXX.desktop"));
QVERIFY(file.open());
const QString fileName = file.fileName();
QTextStream ts(&file);
ts << "[Desktop Entry]\n"
"Type=Application\n"
"Name=My Application\n"
"Exec=kfoo\n"
"TryExec=bash\n"
"X-KDE-AuthorizeAction=someBlockedAction"
"\n";
file.close();
KDesktopFile desktopFile(fileName);
QVERIFY(!desktopFile.tryExec());
}
}
void KDesktopFileTest::testLocateLocal_data()
{
const QString systemConfigLocation = QStandardPaths::standardLocations(QStandardPaths::GenericConfigLocation).constLast();
const QString writableConfigLocation = QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation);
const QString systemDataLocation = QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation).constLast();
const QString writableDataLocation = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation);
QTest::addColumn<QString>("path");
QTest::addColumn<QString>("result");
QTest::newRow("configLocation, system-wide") << systemConfigLocation + QLatin1String{"/test.desktop"}
<< writableConfigLocation + QLatin1String{"/test.desktop"};
QTest::newRow("autostart, system-wide") << systemConfigLocation + QLatin1String{"/autostart/test.desktop"}
<< writableConfigLocation + QLatin1String{"/autostart/test.desktop"};
QTest::newRow("dataLocation, system-wide") << systemDataLocation + QLatin1String{"/test.desktop"} << writableDataLocation + QLatin1String{"/test.desktop"};
QTest::newRow("applications, system-wide") << systemDataLocation + QLatin1String{"/applications/test.desktop"}
<< writableDataLocation + QLatin1String{"/applications/test.desktop"};
QTest::newRow("desktop-directories, system-wide") << systemDataLocation + QLatin1String{"/desktop-directories/test.directory"}
<< writableDataLocation + QLatin1String{"/desktop-directories/test.directory"};
QTest::newRow("configLocation, writable") << writableConfigLocation + QLatin1String{"/test.desktop"}
<< writableConfigLocation + QLatin1String{"/test.desktop"};
QTest::newRow("autostart, writable") << writableConfigLocation + QLatin1String{"/autostart/test.desktop"}
<< writableConfigLocation + QLatin1String{"/autostart/test.desktop"};
QTest::newRow("dataLocation, writable") << writableDataLocation + QLatin1String{"/test.desktop"} << writableDataLocation + QLatin1String{"/test.desktop"};
QTest::newRow("applications, writable") << writableDataLocation + QLatin1String{"/applications/test.desktop"}
<< writableDataLocation + QLatin1String{"/applications/test.desktop"};
QTest::newRow("desktop-directories, writable") << writableDataLocation + QLatin1String{"/desktop-directories/test.directory"}
<< writableDataLocation + QLatin1String{"/desktop-directories/test.directory"};
QTest::newRow("unknown location") << QStringLiteral("/test.desktop") << writableDataLocation + QLatin1String{"/test.desktop"};
}
void KDesktopFileTest::testLocateLocal()
{
QFETCH(QString, path);
QFETCH(QString, result);
QCOMPARE(KDesktopFile::locateLocal(path), result);
}
|