aboutsummaryrefslogtreecommitdiff
path: root/src/kconfig_compiler
diff options
context:
space:
mode:
authorDavid Faure <faure@kde.org>2022-04-24 15:08:59 +0200
committerDavid Faure <faure@kde.org>2022-05-04 09:37:32 +0000
commita0bf7b8e857eba8032e2c828ea2ed0ade09abbad (patch)
tree00da8f36c58a00bf5c8f2547f6f2bcba16a68eec /src/kconfig_compiler
parent329c4f2ef85a1617cabc1b096b33dd114075138c (diff)
downloadkconfig-a0bf7b8e857eba8032e2c828ea2ed0ade09abbad.tar.gz
kconfig-a0bf7b8e857eba8032e2c828ea2ed0ade09abbad.tar.bz2
KConfigGroup: fix writePathEntry/readPathEntry roundtrip for symlinks
If $HOME isn't canonical (e.g. on FreeBSD it's /home/user while the canonical path is /usr/home/user), replacing the canonical version of $HOME with $HOME means that we'll read back a different value than we wrote in. It might seem "equivalent" but it leads to surprises like KRecentDocuments showing duplicates because /usr/home/user became /home/user in the KConfig roundtrip (but not in the XBEL roundtrip). This commit loses the replacement of /usr/home/user with $HOME on FreeBSD, but I think an exact roundtrip is what we expect, rather than stuff being modified under our feet. The alternative would be to canonicalize everything in KRecentDocuments but users don't want to see the /usr in front, I assume (so we would have to use a cache of canonicalized path, for the removal of duplicates, awful performance wise).
Diffstat (limited to 'src/kconfig_compiler')
0 files changed, 0 insertions, 0 deletions