diff options
| author | Ahmad Samir <a.samirh78@gmail.com> | 2020-02-04 20:32:10 +0200 |
|---|---|---|
| committer | Ahmad Samir <a.samirh78@gmail.com> | 2020-04-21 13:53:13 +0200 |
| commit | fb29718d3ac64bdc9e1f2a3d15a506f7798e4a76 (patch) | |
| tree | b96e213b919eb335f7a2027b7d9cc8524a7db927 /src/kconfig_compiler/KConfigXmlParser.cpp | |
| parent | aa28a2433e55cc909c49ed4dbb7ce5c48baa1b24 (diff) | |
| download | kconfig-fb29718d3ac64bdc9e1f2a3d15a506f7798e4a76.tar.gz kconfig-fb29718d3ac64bdc9e1f2a3d15a506f7798e4a76.tar.bz2 | |
Fix some compiler warnings
Summary:
- Fix order of member initialisation (compiling with -Wreorder)
- Use Q_UNUSED where needed
- QAtomicInteger::loadRelaxed() has been available since Qt 5.14
Test Plan: make && ctest
Reviewers: #frameworks, dfaure, apol
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27158
Diffstat (limited to 'src/kconfig_compiler/KConfigXmlParser.cpp')
| -rw-r--r-- | src/kconfig_compiler/KConfigXmlParser.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/kconfig_compiler/KConfigXmlParser.cpp b/src/kconfig_compiler/KConfigXmlParser.cpp index dcbe869f..46ce0921 100644 --- a/src/kconfig_compiler/KConfigXmlParser.cpp +++ b/src/kconfig_compiler/KConfigXmlParser.cpp @@ -166,6 +166,7 @@ void KConfigXmlParser::readParameterFromEntry(CfgEntry &readEntry, const QDomEle bool KConfigXmlParser::hasDefaultCode(CfgEntry &readEntry, const QDomElement &element) { Q_UNUSED(readEntry) + for (QDomElement e = element.firstChildElement(); !e.isNull(); e = e.nextSiblingElement()) { if (e.attribute(QStringLiteral("param")).isEmpty()) { if (e.attribute(QStringLiteral("code")) == QLatin1String("true")) { |