From fb29718d3ac64bdc9e1f2a3d15a506f7798e4a76 Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Tue, 4 Feb 2020 20:32:10 +0200 Subject: Fix some compiler warnings Summary: - Fix order of member initialisation (compiling with -Wreorder) - Use Q_UNUSED where needed - QAtomicInteger::loadRelaxed() has been available since Qt 5.14 Test Plan: make && ctest Reviewers: #frameworks, dfaure, apol Reviewed By: dfaure Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D27158 --- src/kconfig_compiler/KConfigXmlParser.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'src/kconfig_compiler/KConfigXmlParser.cpp') diff --git a/src/kconfig_compiler/KConfigXmlParser.cpp b/src/kconfig_compiler/KConfigXmlParser.cpp index dcbe869f..46ce0921 100644 --- a/src/kconfig_compiler/KConfigXmlParser.cpp +++ b/src/kconfig_compiler/KConfigXmlParser.cpp @@ -166,6 +166,7 @@ void KConfigXmlParser::readParameterFromEntry(CfgEntry &readEntry, const QDomEle bool KConfigXmlParser::hasDefaultCode(CfgEntry &readEntry, const QDomElement &element) { Q_UNUSED(readEntry) + for (QDomElement e = element.firstChildElement(); !e.isNull(); e = e.nextSiblingElement()) { if (e.attribute(QStringLiteral("param")).isEmpty()) { if (e.attribute(QStringLiteral("code")) == QLatin1String("true")) { -- cgit v1.2.1