diff options
| author | Matthew Dawson <matthew@mjdsystems.ca> | 2014-03-28 16:59:51 +0100 |
|---|---|---|
| committer | David Faure <faure@kde.org> | 2014-03-28 17:08:05 +0100 |
| commit | 4846b50aea0bc2262238963a85ab3556c22412e4 (patch) | |
| tree | d77772301de7a6ad0dcc4c160bfea526d29929ac /src/gui | |
| parent | e1ad9a6192d1e2be6fcb17c8a1e961104d921752 (diff) | |
| download | kconfig-4846b50aea0bc2262238963a85ab3556c22412e4.tar.gz kconfig-4846b50aea0bc2262238963a85ab3556c22412e4.tar.bz2 | |
Stop re-loading values inside KCoreConfigSkeleton::save().
The extra load of values in KCoreConfigSkeleton is not documented anywhere
that it happens, and in normal circumstances re-loading new values isn't
expecterd during a save operation.
Update various mentions of readConfig/writeConfig to read/save.
Update documentation to match the new names of functions.
Rename writeConfig() to save() and usrWriteConfig() to usrSave()
Rename functions to match the new naming conventions. Also create old deprecated
instances of both functions to ensure that old code continues to operate
correctly. Also make save() non-virtual, for the same reasons read() is
now non-virtual.
Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig.
Rename usrReadConfig to usrRead, and mark the former as deprecated. To maintain
compatibility, usrRead still calls usrReadConfig in its default implementation.
usrReadConfig remains empty.
REVIEW: 117010
Diffstat (limited to 'src/gui')
| -rw-r--r-- | src/gui/kconfigskeleton.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/gui/kconfigskeleton.h b/src/gui/kconfigskeleton.h index 8262f5ce..f87eef6e 100644 --- a/src/gui/kconfigskeleton.h +++ b/src/gui/kconfigskeleton.h @@ -108,8 +108,8 @@ public: * Register an item of type QColor. * * @param name Name used to identify this setting. Names must be unique. - * @param reference Pointer to the variable, which is set by readConfig() - * calls and read by writeConfig() calls. + * @param reference Pointer to the variable, which is set by read() + * calls and read by save() calls. * @param defaultValue Default value, which is used when the config file * does not yet contain the key of this item. * @param key Key used in config file. If key is null, name is used as key. @@ -123,8 +123,8 @@ public: * Register an item of type QFont. * * @param name Name used to identify this setting. Names must be unique. - * @param reference Pointer to the variable, which is set by readConfig() - * calls and read by writeConfig() calls. + * @param reference Pointer to the variable, which is set by read() + * calls and read by save() calls. * @param defaultValue Default value, which is used when the config file * does not yet contain the key of this item. * @param key Key used in config file. If key is null, name is used as key. |