diff options
author | David Faure <faure@kde.org> | 2019-09-10 09:42:22 +0200 |
---|---|---|
committer | David Faure <faure@kde.org> | 2019-09-17 18:27:06 +0200 |
commit | c34e457bf9506ca068491eda41467013b180e544 (patch) | |
tree | f4708f5dc3d766914e0ee033c70add5ffb43f8e9 /autotests/kconfigloadertest.cpp | |
parent | c358fd68e27738340582386d7f1c1c2fccac7df2 (diff) | |
download | kconfig-c34e457bf9506ca068491eda41467013b180e544.tar.gz kconfig-c34e457bf9506ca068491eda41467013b180e544.tar.bz2 |
[KConfig] port away from deprecated methods in Qt 5.14
Summary:
In kconf_update, the ctime usage used to be about metadata change time
(buff.st_ctime, before it got ported to the misnamed created()).
I ported it to birthTime, because I think
date of birth is a more useful way to identify a file than
date of permission change which doesn't really matter to us.
But in practice, I can't help but wonder if mtime alone wouldn't be
enough.
For the QStringLiteral("%%1").arg(i) bit, I tested it in tst_qstring,
the first % is left untouched.
Test Plan: make && ctest
Reviewers: mdawson, arichardson, vkrause
Reviewed By: vkrause
Subscribers: pino, arojas, mlaurent, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23815
Diffstat (limited to 'autotests/kconfigloadertest.cpp')
-rw-r--r-- | autotests/kconfigloadertest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/autotests/kconfigloadertest.cpp b/autotests/kconfigloadertest.cpp index 1c818b7f..eae1e2b2 100644 --- a/autotests/kconfigloadertest.cpp +++ b/autotests/kconfigloadertest.cpp @@ -161,7 +161,7 @@ void ConfigLoaderTest::intListDefaultValue() expected.append(5); expected.append(8); - QVERIFY(typeItem->isEqual(qVariantFromValue(expected))); + QVERIFY(typeItem->isEqual(QVariant::fromValue(expected))); } void ConfigLoaderTest::longLongDefaultValue() |