diff options
| author | Albert Astals Cid <aacid@kde.org> | 2019-01-10 20:44:17 +0100 |
|---|---|---|
| committer | Albert Astals Cid <aacid@kde.org> | 2019-01-10 20:44:20 +0100 |
| commit | 78da515c5deb984452524069cf7c62a6a68be626 (patch) | |
| tree | f4129ad8679b54a2097de265eae01e606fbd6210 | |
| parent | 82a1dab0eea69986fe3e54ff6a330e1f473f0cb3 (diff) | |
| download | kconfig-78da515c5deb984452524069cf7c62a6a68be626.tar.gz kconfig-78da515c5deb984452524069cf7c62a6a68be626.tar.bz2 | |
KEmailSettings: Delete copy constructor and assignment operator
Summary:
If someone was using them, it'd crash since it was raw-copying the d pointer
so you would end up with a double delete.
This is SIC, but IMHO it's fine, whoever gets a compiler failure has a bug to fix
Reviewers: vkrause
Reviewed By: vkrause
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D18135
| -rw-r--r-- | src/core/kemailsettings.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/core/kemailsettings.h b/src/core/kemailsettings.h index 4d2f0d50..7d4fb8cf 100644 --- a/src/core/kemailsettings.h +++ b/src/core/kemailsettings.h @@ -117,6 +117,9 @@ public: **/ KEMailSettings(); + KEMailSettings(const KEMailSettings &) = delete; + KEMailSettings& operator=(const KEMailSettings &) = delete; + /** * Default destructor, nothing to see here. **/ |