diff options
author | Harald Sitter <sitter@kde.org> | 2019-08-19 15:59:37 +0200 |
---|---|---|
committer | Harald Sitter <sitter@kde.org> | 2019-08-19 16:30:30 +0200 |
commit | 557e5d898bf95cfb999c1a0a4d9bd0c4bd5fe178 (patch) | |
tree | 9a5350437ddd6b0bb5b6cec902da0813532c3cf5 /modules/ECMAddQtDesignerPlugin.cmake | |
parent | 60ca1a27e53999721df1194813c9e670f6ffcc4a (diff) | |
download | extra-cmake-modules-557e5d898bf95cfb999c1a0a4d9bd0c4bd5fe178.tar.gz extra-cmake-modules-557e5d898bf95cfb999c1a0a4d9bd0c4bd5fe178.tar.bz2 |
disable autouic again - it breaks builds
Summary:
autouic (like automoc) assumes that every ui_*.h include statement it finds
relates to a .ui file that needs generating. this is not always true.
e.g. we have software which generates ui_debug.h which is simply
a qloggingcategory header for the UI category of that software which would
then trip up autouic because it would assume there's a .ui file when there
really isn't one.
unfortunately the ui_ assumption cannot be selectively disabled, so we
can't have explicit listing of .ui in source lists
```
set(foo_SRCS foo.cpp foo.ui)
```
without also getting the not particularly compatible include assumptions.
this should be revisited for kf6 since there isn't a technical need for
files to be called ui_*, they could just as well be *_ui or anything else
so as to not clash with autouic assumption.
autorcc does not suffer from this problem so we can leave it enabled, for
now anyway.
Test Plan: sonnet builds again
Reviewers: apol, nicolasfella, cullmann
Reviewed By: apol
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D23262
Diffstat (limited to 'modules/ECMAddQtDesignerPlugin.cmake')
0 files changed, 0 insertions, 0 deletions