diff options
| author | Stephen Kelly <steveire@gmail.com> | 2017-01-03 00:25:51 +0000 |
|---|---|---|
| committer | Stephen Kelly <steveire@gmail.com> | 2017-01-03 00:25:51 +0000 |
| commit | 4a986d8db8e9b594679b008fd70b818ef2ad94a5 (patch) | |
| tree | c827696132da94e288896a0c848bea8368a74143 /kde-modules | |
| parent | 5ed7ba07e4f382f4e07e2de7feca33c16a2793f7 (diff) | |
| download | extra-cmake-modules-4a986d8db8e9b594679b008fd70b818ef2ad94a5.tar.gz extra-cmake-modules-4a986d8db8e9b594679b008fd70b818ef2ad94a5.tar.bz2 | |
Revert "Enable -Wsuggest-override for g++ >= 5.0.0"
This reverts commit d1d637fadd6dad68995d44101250ebbc3307ed0b.
This is far too noisy.
The correct steps for this kind of change are:
* Enable the warning locally
* Take the action recommended by the warning in the code, and push the
result
* Push the warning on everyone to enforce that the code stays fixed for
the future
Diffstat (limited to 'kde-modules')
| -rw-r--r-- | kde-modules/KDEFrameworkCompilerSettings.cmake | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/kde-modules/KDEFrameworkCompilerSettings.cmake b/kde-modules/KDEFrameworkCompilerSettings.cmake index 3998f8af..038ddc3b 100644 --- a/kde-modules/KDEFrameworkCompilerSettings.cmake +++ b/kde-modules/KDEFrameworkCompilerSettings.cmake @@ -63,9 +63,6 @@ endif() if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic") - if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0.0") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override" ) - endif() elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") # -Wgnu-zero-variadic-macro-arguments is triggered by every qCDebug() call and therefore results # in a lot of noise. This warning is only notifying us that clang is emulating the GCC behaviour |