aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDirk Mueller <mueller@kde.org>2006-04-11 23:48:23 +0000
committerDirk Mueller <mueller@kde.org>2006-04-11 23:48:23 +0000
commite13a70a79582b8dbe37f979ee4516558877ece48 (patch)
treee171023388c76669fc114fd7265c4ff057614cc9
parente501bce2a9bed00d3730739c1ba558f302169065 (diff)
downloadextra-cmake-modules-e13a70a79582b8dbe37f979ee4516558877ece48.tar.gz
extra-cmake-modules-e13a70a79582b8dbe37f979ee4516558877ece48.tar.bz2
the usual security fixes:
- add proper quoting - add proper LD_LIBRARY_PATH export's - don't make world executable. Ok, it would be better to honor umask, but I don't know how to do that.. svn path=/trunk/KDE/kdelibs/; revision=528894
-rwxr-xr-xmodules/kde4_exec_via_sh.cmake4
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/kde4_exec_via_sh.cmake b/modules/kde4_exec_via_sh.cmake
index 14d2eca7..c8060b9a 100755
--- a/modules/kde4_exec_via_sh.cmake
+++ b/modules/kde4_exec_via_sh.cmake
@@ -3,9 +3,9 @@ file(WRITE "${_filename}"
"#!/bin/sh
# created by cmake, don't edit, changes will be lost
-${_library_path_variable}=${_ld_library_path}:$${_library_path_variable} \"${_executable}\" $@
+${_library_path_variable}=${_ld_library_path}\${${_library_path_variable}+:${_library_path_variable}} \"${_executable}\" \"$@\"
")
# make it executable
# since this is only executed on UNIX, it is safe to call chmod
-exec_program(chmod ARGS 755 \"${_filename}\" OUTPUT_VARIABLE _dummy )
+exec_program(chmod ARGS ug+x \"${_filename}\" OUTPUT_VARIABLE _dummy )