diff options
| author | Alex Merry <kde@randomguy3.me.uk> | 2014-01-28 16:07:57 +0000 |
|---|---|---|
| committer | Alex Merry <kde@randomguy3.me.uk> | 2014-01-28 16:07:57 +0000 |
| commit | 5e43bbb48163caae5cbae91598b33abd33a4c239 (patch) | |
| tree | 25a88a8453294445743320ef1bd5abe3f7fefe96 | |
| parent | 81233a524e0b18123201d0a7ca72b87ce8b8625b (diff) | |
| download | extra-cmake-modules-5e43bbb48163caae5cbae91598b33abd33a4c239.tar.gz extra-cmake-modules-5e43bbb48163caae5cbae91598b33abd33a4c239.tar.bz2 | |
Better documentation for system API defines
| -rw-r--r-- | kde-modules/KDECompilerSettings.cmake | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/kde-modules/KDECompilerSettings.cmake b/kde-modules/KDECompilerSettings.cmake index 6b7ab4ed..3419cb12 100644 --- a/kde-modules/KDECompilerSettings.cmake +++ b/kde-modules/KDECompilerSettings.cmake @@ -79,17 +79,23 @@ endmacro() if (UNIX) # Enable basically everything portable across modern UNIX systems. - # See http://www.delorie.com/gnu/docs/glibc/libc_13.html + # See http://www.delorie.com/gnu/docs/glibc/libc_13.html, although + # this define is for the benefit of other libc implementations + # (since _GNU_SOURCE is defined below). + _kde_add_platform_definitions(-D_XOPEN_SOURCE=500) + + # Enable everything in GNU libc. Any code using non-portable features + # needs to perform feature tests, but this ensures that any such features + # will be found if they exist. # # NB: we do NOT define _BSD_SOURCE, as with GNU libc that requires linking # against the -lbsd-compat library (it changes the behaviour of some # functions). - _kde_add_platform_definitions(-D_XOPEN_SOURCE=500) - # FIXME: do we need this? _kde_add_platform_definitions(-D_GNU_SOURCE) # Enable extra API for using 64-bit file offsets on 32-bit systems. - # FIXME: do we need this? Does it make sense on non-glibc systems? + # FIXME: this is included in _GNU_SOURCE in glibc; do other libc + # implementation recognize it? _kde_add_platform_definitions(-D_LARGEFILE64_SOURCE) endif() |