diff options
| author | Friedrich W. H. Kossebau <kossebau@kde.org> | 2018-06-29 20:39:18 +0200 |
|---|---|---|
| committer | Friedrich W. H. Kossebau <kossebau@kde.org> | 2018-06-29 23:58:37 +0200 |
| commit | 484d5f4ceea2b8d23c9a0d35f16077f7cabfbd27 (patch) | |
| tree | 9e9bc5703e5f893e640c81a3bd3dc860ee3312b5 | |
| parent | 60cb4b74bce8bc0f65ea3dc2cd7966602dd50694 (diff) | |
| download | extra-cmake-modules-484d5f4ceea2b8d23c9a0d35f16077f7cabfbd27.tar.gz extra-cmake-modules-484d5f4ceea2b8d23c9a0d35f16077f7cabfbd27.tar.bz2 | |
Drop outdated QT_USE_FAST_OPERATOR_PLUS
Summary:
QT_USE_FAST_OPERATOR_PLUS has been deprecated in Qt 4.8, in favour of
QT_USE_QSTRINGBUILDER. The latter also covers QByteArray.
Qt5 headers still supports QT_USE_FAST_OPERATOR_PLUS (at least 5.11.1),
as subset of QT_USE_QSTRINGBUILDER as it was introduced in Qt4.8,
but not as documented build flag.
Given QT_USE_QSTRINGBUILDER is set here and thus triggers anything that
QT_USE_FAST_OPERATOR_PLUS would trigger in Qt code, removing it should
clean up the macro from undocumented features and thus reduce confusion.
No non-Qt is known at least in KDE repos which checks this build flag
otherwise, so no regression should be expected here as well.
Reviewers: vkrause
Reviewed By: vkrause
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D13800
| -rw-r--r-- | kde-modules/KDEFrameworkCompilerSettings.cmake | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kde-modules/KDEFrameworkCompilerSettings.cmake b/kde-modules/KDEFrameworkCompilerSettings.cmake index 709ddf09..6a82f75e 100644 --- a/kde-modules/KDEFrameworkCompilerSettings.cmake +++ b/kde-modules/KDEFrameworkCompilerSettings.cmake @@ -53,7 +53,6 @@ add_definitions(-DQT_NO_CAST_TO_ASCII -DQT_NO_URL_CAST_FROM_STRING -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_SIGNALS_SLOTS_KEYWORDS - -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER ) |