diff options
| author | David Faure <faure@kde.org> | 2016-06-18 00:23:40 +0200 |
|---|---|---|
| committer | David Faure <faure@kde.org> | 2016-09-02 16:36:00 +0200 |
| commit | 413eb26f5d9e7a7f174509f8a16d057d5c0e6578 (patch) | |
| tree | 7253726eaf3117f1ac7a0b213b5a3b175459090e | |
| parent | 040440eb9ebfa756adc6b31f53d8e733fd0da3c9 (diff) | |
| download | extra-cmake-modules-413eb26f5d9e7a7f174509f8a16d057d5c0e6578.tar.gz extra-cmake-modules-413eb26f5d9e7a7f174509f8a16d057d5c0e6578.tar.bz2 | |
The default level for logging categories should be Info rather than Warning.
The whole point of Info is to be used by apps who want to print out some
info for the user, not disabled by default.
Example use case: ksmserver could output the name of the autostart
files it's starting, so user can check their own scripts are started,
and associate any errors with the corresponding script.
In other words:
Debug = debugging for the developer
Info = debugging for the user :-)
This commit shows the benefit of having a central place for changing this
(many category definitions do not use this macro though)
REVIEW: 128232
| -rw-r--r-- | modules/ECMQtDeclareLoggingCategory.cmake | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/ECMQtDeclareLoggingCategory.cmake b/modules/ECMQtDeclareLoggingCategory.cmake index 95126411..bbed53ca 100644 --- a/modules/ECMQtDeclareLoggingCategory.cmake +++ b/modules/ECMQtDeclareLoggingCategory.cmake @@ -25,7 +25,7 @@ # # If the code is compiled against Qt 5.4 or later, by default it will only log # output that is at least the severity specified by ``DEFAULT_SEVERITY``, or -# "Warning" level if ``DEFAULT_SEVERITY`` is not given. Note that, due to a +# "Info" level if ``DEFAULT_SEVERITY`` is not given. Note that, due to a # bug in Qt 5.5, "Info" may be treated as more severe than "Fatal". # # ``<identifier>`` may include namespaces (eg: ``foo::bar::IDENT``). @@ -82,7 +82,7 @@ function(ecm_qt_declare_logging_category sources_var) message(FATAL_ERROR "Missing CATEGORY_NAME argument for ecm_qt_declare_logging_category") endif() if(NOT ARG_DEFAULT_SEVERITY) - set(ARG_DEFAULT_SEVERITY Warning) + set(ARG_DEFAULT_SEVERITY Info) else() set(acceptible_severities Debug Info Warning Critical Fatal) list(FIND acceptible_severities "${ARG_DEFAULT_SEVERITY}" pos) |