aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorR.J.V. Bertin <rjvbertin@gmail.com>2016-12-11 19:03:31 +0100
committerR.J.V. Bertin <rjvbertin@gmail.com>2016-12-11 19:03:31 +0100
commit187d8881a6a0c33f50eb65689aa1dd74a8d107a4 (patch)
tree5cd7550a0b3cce9b5545ffe489edbb29c89f404a
parentea6d3a16bd6771b8d52641e27a3593cf580adb1f (diff)
downloadextra-cmake-modules-187d8881a6a0c33f50eb65689aa1dd74a8d107a4.tar.gz
extra-cmake-modules-187d8881a6a0c33f50eb65689aa1dd74a8d107a4.tar.bz2
Never use -Wl,--no-undefined on Mac (APPLE).
While unusual it is not impossible to use GCC on Macs, esp. not when using older OS X versions. Intel also makes compilers for Mac, so it may in fact be better to rewrite the check ((GNU or Clang or Intel) IF NOT (APPLE or WIN32)).
-rw-r--r--kde-modules/KDECompilerSettings.cmake2
1 files changed, 1 insertions, 1 deletions
diff --git a/kde-modules/KDECompilerSettings.cmake b/kde-modules/KDECompilerSettings.cmake
index f81b6610..8b458f55 100644
--- a/kde-modules/KDECompilerSettings.cmake
+++ b/kde-modules/KDECompilerSettings.cmake
@@ -332,7 +332,7 @@ endfunction()
# Better diagnostics (warnings, errors)
############################################################
-if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR
+if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE) OR
(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND NOT APPLE) OR
(CMAKE_CXX_COMPILER_ID STREQUAL "Intel" AND NOT WIN32))
# Linker warnings should be treated as errors