aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlbert Astals Cid <aacid@kde.org>2017-01-23 20:04:47 +0100
committerAlbert Astals Cid <aacid@kde.org>2017-01-23 20:04:47 +0100
commitfaeb56f8137d738d1dfbc1fcfbbacd1e8caeb6f0 (patch)
treea05b3f85ec0818b79697c4d954a6f40bacdf4192
parent1bb97996f4f5195703bfa37767a2cce447ab70ac (diff)
downloadextra-cmake-modules-faeb56f8137d738d1dfbc1fcfbbacd1e8caeb6f0.tar.gz
extra-cmake-modules-faeb56f8137d738d1dfbc1fcfbbacd1e8caeb6f0.tar.bz2
Enable -Wsuggest-override for g++ >= 5.0.0
REVIEW: 129724
-rw-r--r--kde-modules/KDEFrameworkCompilerSettings.cmake3
1 files changed, 3 insertions, 0 deletions
diff --git a/kde-modules/KDEFrameworkCompilerSettings.cmake b/kde-modules/KDEFrameworkCompilerSettings.cmake
index 038ddc3b..3998f8af 100644
--- a/kde-modules/KDEFrameworkCompilerSettings.cmake
+++ b/kde-modules/KDEFrameworkCompilerSettings.cmake
@@ -63,6 +63,9 @@ endif()
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic")
+ if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0.0")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override" )
+ endif()
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
# -Wgnu-zero-variadic-macro-arguments is triggered by every qCDebug() call and therefore results
# in a lot of noise. This warning is only notifying us that clang is emulating the GCC behaviour