From faeb56f8137d738d1dfbc1fcfbbacd1e8caeb6f0 Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Mon, 23 Jan 2017 20:04:47 +0100 Subject: Enable -Wsuggest-override for g++ >= 5.0.0 REVIEW: 129724 --- kde-modules/KDEFrameworkCompilerSettings.cmake | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kde-modules/KDEFrameworkCompilerSettings.cmake b/kde-modules/KDEFrameworkCompilerSettings.cmake index 038ddc3b..3998f8af 100644 --- a/kde-modules/KDEFrameworkCompilerSettings.cmake +++ b/kde-modules/KDEFrameworkCompilerSettings.cmake @@ -63,6 +63,9 @@ endif() if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic") + if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0.0") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override" ) + endif() elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") # -Wgnu-zero-variadic-macro-arguments is triggered by every qCDebug() call and therefore results # in a lot of noise. This warning is only notifying us that clang is emulating the GCC behaviour -- cgit v1.2.1