aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2017-05-25API dox: note CamelCase includes by @class tag with more classesFriedrich W. H. Kossebau
2017-04-25Fix relativePath calculation in KDesktopFile::locateLocal()Wolfgang Bauer
The "dir" and "path" variables were obviously swapped here by mistake. This resulted in the relativePath always being empty, and made the function return "~/.local/share/" (or "~/.config/") instead of the correct path. BUG: 345100 FIXED-IN: 5.34.0 Differential Revision: https://phabricator.kde.org/D5502
2017-03-15Remove unused QDateTime in KConfigBackend.David Faure
Spotted because it leads to race conditions due to tzset (surely a Qt bug, but anyway no point in finding out lastModified for nothing). While at it, remove the unused size field as well.
2017-03-15Now that kconfigbackend.h isn't installed anymore, rename it to _p.h for ↵David Faure
clarity.
2017-03-06Sanitize shortcut list on read/write from kdeglobalsAlbert Astals Cid
For some reason some people have kdeglobals entries like Close=Ctrl+W; Ctrl+Esc; Ctrl+W; Ctrl+Esc; having the same shortcut more than once in the shortcut declaration is clearly bogus so fix it BUGS: 375555 REVIEW: 129987
2017-03-05avoid useless reallocs by removing squeeze call on temporary bufferChristoph Cullmann
Differential Revision: https://phabricator.kde.org/D4941
2017-02-21KConfig: stop exporting and installing KConfigBackend.David Faure
Summary: It can't possibly have been used anywhere, because it's not in the KConfig API anywhere. The intended way to use this API was by providing a plugin that would derive from KConfigBackend but the plugin loading code in KConfigBackend::create has been disabled since before KF 5.0. The reason I want to stop exporting this class is to be able to optimize it (e.g. the QDateTime in it is completely unused but leads to data races due to tzset) Test Plan: Note, I'll rename it to _p.h if we agree, it would just have made this diff too big. Reviewers: mdawson Reviewed By: mdawson Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D4604
2017-02-14GIT_SILENT remove comment about this being a temp workaround.David Faure
Even with 5.8 we need it, not due to QLockFile, but just due to mainConfigName(), see unittest ksharedconfig_in_global_object
2017-02-04Fix linking on Windows: don't link kentrymaptest to KConfigCore.David Faure
It's not needed, this is purely a test for the standalone KEntryMap class.
2017-02-04Don't export KEntryMapStephen Kelly
It is internal.
2017-01-16Prefer nullptr over Q_NULLPTRKevin Funk
2017-01-16Use nullptr everywhereKevin Funk
Differential Revision: https://phabricator.kde.org/D3987
2017-01-16Fix a few -Wdocumentation warningsKevin Funk
2017-01-15Add python bindingsStephen Kelly
2017-01-15Add missing export decorationStephen Kelly
2017-01-08Update message, kdeui doesn't exist anymore.David Faure
2017-01-06Generate an instance with KSharedConfig::Ptr for singleton and argMartin Gräßlin
Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. The change is source-incompatible in the following situation: * kcfgfile arg="true" * Singleton = true * Inherits is specified In this situation the previous revision created an instance method with a QString argument and passed that to the parent constructor. This is not in accordance with the documentation. Any user of this behavior was relying on a bug. With this change now the call to the parent constructor carries a KSharedConfigPtr. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks, dfaure, mdawson Differential Revision: https://phabricator.kde.org/D3690
2017-01-03Fix build with CMP 0026 set to NEWSven Brauch
2017-01-02Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAGAlbert Astals Cid
REVIEW: 129745
2016-12-21SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-12-20SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-12-17[kconfig_compiler] Improve documentation about InheritsMartin Gräßlin
Summary: Better specify the requirements the parent class needs to have. KConfigCompiler generates different variants of ctors taking either: * a QStringLiteral argument (name set in <kcfgfile> * a KSharedConfig::Ptr argument (arg="true" in <kcfgfile>) * no argument (Inherits=true in kcfgc and no <kcfgfile>) In order to have Inherits generate compiling code in all cases the parent class needs to provide accessible ctors. This change updates the docuementation to reflect this. Reviewers: #frameworks, dfaure Differential Revision: https://phabricator.kde.org/D3636
2016-12-16kconfig_compiler: Use nullptr in generated codeKevin Funk
Reviewers: #frameworks, davidedmundson Reviewed By: davidedmundson Differential Revision: https://phabricator.kde.org/D3702
2016-12-07Revert "Generate an instance with KSharedConfig::Ptr for singleton and arg"David Faure
This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839. As suggested by Martin on release-team@kde.org, given that it breaks SC.
2016-12-02Generate an instance with KSharedConfig::Ptr for singleton and argMartin Gräßlin
Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. This provides full API compatibility and at the same time allows to use KSharedConfig in addition to the arg name based variant. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks Differential Revision: https://phabricator.kde.org/D3386
2016-11-17Properly test environment variableAleix Pol
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty() Reviewers: #frameworks, sebas, sitter Reviewed By: sebas, sitter Differential Revision: https://phabricator.kde.org/D3314
2016-11-12kconfig_compiler - generate code with overridesAllen Winter
REVIEW: 129382
2016-11-10src/core/kconfigbackend.cpp - handle unused 'sys' argumentAllen Winter
2016-10-24Add documentation for the GenerateProperties optionElvis Angelaccio
REVIEW: 129188
2016-10-02Fix memory leak in SignalsTestNoSingletonDpointer, found by ASAN.David Faure
2016-08-14Add Donate standard shortcutElvis Angelaccio
REVIEW: 128608 CHANGELOG: Add Donate entry to KStandardShortcut
2016-08-04api docs: add version to @deprecated tag for authorizeKActionDavid Faure
2016-08-01Add DeleteFile and RenameFile standard shortcut.Leslie Zhai
REVIEW: 128517
2016-07-13Reduce string modifications when calling translatePathAleix Pol
Don't drop the file: prefix twice in every run. Use appropriate API on paths rather than string handling, when possible. REVIEW: 127813
2016-07-02Fix previous commit - this still needs to be exportedDavid Faure
CCMAIL: elvis.angelaccio@kdemail.net
2016-07-02Deprecate authorizeKAction() in favor of authorizeAction()Elvis Angelaccio
REVIEW: 128023
2016-06-22Fix reproducibility in builds by ensuring utf-8 encoding.Scarlett Clark
REVIEW:128102 Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible builds ) Under certain locals non standard characters will get dropped making builds un reproducible. Setting the encoding to utf-8 on the files makes all builds reproducible no matter what ( or none ) locale is in use. Thereby making the build reproducible.
2016-05-19Avoid skipping KAuthorized checkDavid Edmundson
Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction entry we would skip the KAuthorized check. This is clearly wrong. REVIEW: 127948
2016-05-11Remove not-implemented functionStephen Kelly
No one could be using this because they would not be able to link,
2016-05-11Remove typedef copyStephen Kelly
The typedef is copied here to avoid including the header that contains it. However, this confuses sip if binding definitions are generated from the C++ headers. Simply inline the typedef instead.
2016-04-27Make kdeglobals file path static as intendedAleix Pol
2016-04-27Remove unneeded ifdefs to compare pathsAleix Pol
Just keep the setting once and always use QString::compare instead of using QString::operator== or QString::compare depending on the platform.
2016-04-27Remove unused variableAleix Pol
2016-04-17core/ksharedconfig.cpp - pedanticAllen Winter
2016-03-28Add support for get QStandardPaths locations.Sandro Knauß
Inside desktop files we want to reach also data, cache and config home to create files inside these directories. REVIEW: 127462 CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
2016-02-19KConfigIniBackend: Fix expensive detach in lookupKevin Funk
Differential Revision: https://phabricator.kde.org/D990
2016-01-20SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-01-02Qt 5.3 is required, remove code for < 5.3David Faure
2015-12-29Ensure KonfUpdate's fields are all initialized.Matthew Dawson
These fields should all be written to before they are read during normal operation, but this ensures they have a sensible default in case they are not. Coverity issue 1291513.
2015-12-29Remove unused variable in KConfigPrivateMatthew Dawson
This seems to be left over from KDE 3.5 times, and isn't referenced anywhere in the code. Since its a private header, just remove. Found by Coverity, issue 1175531. REVIEW: 126555