aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2017-01-06Generate an instance with KSharedConfig::Ptr for singleton and argMartin Gräßlin
Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. The change is source-incompatible in the following situation: * kcfgfile arg="true" * Singleton = true * Inherits is specified In this situation the previous revision created an instance method with a QString argument and passed that to the parent constructor. This is not in accordance with the documentation. Any user of this behavior was relying on a bug. With this change now the call to the parent constructor carries a KSharedConfigPtr. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks, dfaure, mdawson Differential Revision: https://phabricator.kde.org/D3690
2017-01-03Fix build with CMP 0026 set to NEWSven Brauch
2017-01-02Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAGAlbert Astals Cid
REVIEW: 129745
2016-12-21SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-12-20SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-12-17[kconfig_compiler] Improve documentation about InheritsMartin Gräßlin
Summary: Better specify the requirements the parent class needs to have. KConfigCompiler generates different variants of ctors taking either: * a QStringLiteral argument (name set in <kcfgfile> * a KSharedConfig::Ptr argument (arg="true" in <kcfgfile>) * no argument (Inherits=true in kcfgc and no <kcfgfile>) In order to have Inherits generate compiling code in all cases the parent class needs to provide accessible ctors. This change updates the docuementation to reflect this. Reviewers: #frameworks, dfaure Differential Revision: https://phabricator.kde.org/D3636
2016-12-16kconfig_compiler: Use nullptr in generated codeKevin Funk
Reviewers: #frameworks, davidedmundson Reviewed By: davidedmundson Differential Revision: https://phabricator.kde.org/D3702
2016-12-07Revert "Generate an instance with KSharedConfig::Ptr for singleton and arg"David Faure
This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839. As suggested by Martin on release-team@kde.org, given that it breaks SC.
2016-12-02Generate an instance with KSharedConfig::Ptr for singleton and argMartin Gräßlin
Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. This provides full API compatibility and at the same time allows to use KSharedConfig in addition to the arg name based variant. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks Differential Revision: https://phabricator.kde.org/D3386
2016-11-17Properly test environment variableAleix Pol
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty() Reviewers: #frameworks, sebas, sitter Reviewed By: sebas, sitter Differential Revision: https://phabricator.kde.org/D3314
2016-11-12kconfig_compiler - generate code with overridesAllen Winter
REVIEW: 129382
2016-11-10src/core/kconfigbackend.cpp - handle unused 'sys' argumentAllen Winter
2016-10-24Add documentation for the GenerateProperties optionElvis Angelaccio
REVIEW: 129188
2016-10-02Fix memory leak in SignalsTestNoSingletonDpointer, found by ASAN.David Faure
2016-08-14Add Donate standard shortcutElvis Angelaccio
REVIEW: 128608 CHANGELOG: Add Donate entry to KStandardShortcut
2016-08-04api docs: add version to @deprecated tag for authorizeKActionDavid Faure
2016-08-01Add DeleteFile and RenameFile standard shortcut.Leslie Zhai
REVIEW: 128517
2016-07-13Reduce string modifications when calling translatePathAleix Pol
Don't drop the file: prefix twice in every run. Use appropriate API on paths rather than string handling, when possible. REVIEW: 127813
2016-07-02Fix previous commit - this still needs to be exportedDavid Faure
CCMAIL: elvis.angelaccio@kdemail.net
2016-07-02Deprecate authorizeKAction() in favor of authorizeAction()Elvis Angelaccio
REVIEW: 128023
2016-06-22Fix reproducibility in builds by ensuring utf-8 encoding.Scarlett Clark
REVIEW:128102 Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible builds ) Under certain locals non standard characters will get dropped making builds un reproducible. Setting the encoding to utf-8 on the files makes all builds reproducible no matter what ( or none ) locale is in use. Thereby making the build reproducible.
2016-05-19Avoid skipping KAuthorized checkDavid Edmundson
Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction entry we would skip the KAuthorized check. This is clearly wrong. REVIEW: 127948
2016-05-11Remove not-implemented functionStephen Kelly
No one could be using this because they would not be able to link,
2016-05-11Remove typedef copyStephen Kelly
The typedef is copied here to avoid including the header that contains it. However, this confuses sip if binding definitions are generated from the C++ headers. Simply inline the typedef instead.
2016-04-27Make kdeglobals file path static as intendedAleix Pol
2016-04-27Remove unneeded ifdefs to compare pathsAleix Pol
Just keep the setting once and always use QString::compare instead of using QString::operator== or QString::compare depending on the platform.
2016-04-27Remove unused variableAleix Pol
2016-04-17core/ksharedconfig.cpp - pedanticAllen Winter
2016-03-28Add support for get QStandardPaths locations.Sandro Knauß
Inside desktop files we want to reach also data, cache and config home to create files inside these directories. REVIEW: 127462 CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
2016-02-19KConfigIniBackend: Fix expensive detach in lookupKevin Funk
Differential Revision: https://phabricator.kde.org/D990
2016-01-20SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-01-02Qt 5.3 is required, remove code for < 5.3David Faure
2015-12-29Ensure KonfUpdate's fields are all initialized.Matthew Dawson
These fields should all be written to before they are read during normal operation, but this ensures they have a sensible default in case they are not. Coverity issue 1291513.
2015-12-29Remove unused variable in KConfigPrivateMatthew Dawson
This seems to be left over from KDE 3.5 times, and isn't referenced anywhere in the code. Since its a private header, just remove. Found by Coverity, issue 1175531. REVIEW: 126555
2015-12-29Ensure group is unescaped properly in kconf_update.Matthew Dawson
During a kconf_update run, an invalid group name may be treated as correct even though the name failed to unescape. This leads the group name to be a null character, which will fail. If the unescape failed, return that failure status instead. This should have no impact, as the previous result would have been wrong anyways. Now a more useful diagnostic will be returned instead. Update the unit tests to ensure this issue is tested in the future. Found in Coverity issue 258087. REVIEW: 126556
2015-12-29Remove duplicate branch in kconfig_compiler.cppMatthew Dawson
This has been around for a long time, no need to dupilcate. Coverity issue 1289077.
2015-12-23gui: add a small apidox bit for the KConfigGui namespacePino Toscano
This way it can be shown in the apidox.
2015-12-23Fix some Clazy warningsImran Tatriev
2015-11-21SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2015-11-04SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2015-11-03Fix usage of ecm_create_qm_loader.Alex Merry
Generate-source-file macros should be used from the same CMakeLists.txt file as the targets they generate files for.
2015-10-30Use QStringLiteral in generated codeMontel Laurent
REVIEW: 125833
2015-10-20use KDE_INSTALL_FULL_ variant, so there is no ambiguityRex Dieter
2015-10-17Allow KConfig to use resources as fallback config filesChristoph Cullmann
Fallback will be :/kconfig/ REVIEW: 125598
2015-10-05Minor optimizationsAlbert Astals Cid
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/) Mostly QStringLiteral/QLatin1String additions A few const & additions to non public methods Compiles, test pass REVIEW: 125106
2015-09-25Mark kconfig-compiler as non-gui toolHarald Fernengel
Makes sure that it doens't create an app bundle on Mac OS X REVIEW: 125337
2015-09-07[KDesktopFile] add readMimeTypesKai Uwe Broulik
CHANGELOG: KDesktopFile can now read mime types specified in the MimeType field REVIEW: 124746
2015-08-22Optimize readEntryGuiKevin Funk
Don't build error string every time REVIEW: 124879
2015-08-19Rename private class to avoid exporting it accidentallyMontel Laurent
2015-08-19Fix pedanticMontel Laurent
generated by cgit v1.2.1 (git 2.18.0) at 2025-05-05 19:05:13 +0000