Age | Commit message (Collapse) | Author |
|
This makes it follow the pattern of other "Configure X" style
actions. See also the discussion in
https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/4#note_60691
|
|
It will assert.
|
|
char*)
KStandardShortcut::name returns a QString, this makes the api symmetric and more
straightforward to use.
|
|
qstrcmp returns 0 if two strings are equal.
|
|
Summary:
Add a standard shortcut for this action so it can be synchronized between different apps
and the file dialog; see https://bugs.kde.org/show_bug.cgi?id=262551.
The action in Dolphin also has F8 bound to this, but the definition here only accept two
default shortcuts, and F8 seems kind of random.
CCBUG: 262551
Test Plan: Apply D28803 to KIO and D28804 to Dolphin and test there
Reviewers: dfaure, #frameworks
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D28802
|
|
Summary:
This is an addendum for commit a2774ff5b41987c3919a9e; making the check
tighter.
Test Plan: make && ctest
Reviewers: #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27811
|
|
Summary:
Convert license headers to SPDX statements and add
license files as required by REUSE specification.
Reviewers: cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: ognarb, cgiboudeaux, kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T11550
Differential Revision: https://phabricator.kde.org/D27601
|
|
|
|
Summary:
If the styleName property is set for a QFont, using setBold(true) would
lead to Qt using an "emboldended"/synthetic font style instead of using
the bold style provided by the font itself (usually as a standalone font
file), the former looks ugly (IIUC, Freetype emboldens fonts as a last
resort for fonts that don't provide a bold style at all).
Accoring to upstream[1] the styleName property is useful for fonts with
fancy style names, and also it shouldn't be set if it's not needed; and
indeed using styleName with e.g. "Regular" doesn't make sense, as there
is no "Regular Bold" style AFAICS.
Checking for "Regular|Normal|Book|Roman" is based on examining the font
styles provided by the font packages available on OpenSuse Tumbleweed ATM,
(I didn't include some of the weird/non-common ones e.g. I've seen "Roma"
and "Rounded"). Some statistics about the "Regular"-like font styles from
my testing:
Regular: 2486
Normal: 66
Book: 20
Roman: 13
For more details see:
[1] https://bugreports.qt.io/browse/QTBUG-63792
https://bugs.kde.org/show_bug.cgi?id=378523
BUG: 378523
FIXED-IN: 5.68
Test Plan:
All unit tests still pass.
Changing the fonts via e.g. the fonts KCM doesn't append the font sytleName,
to the relevant font config entry, if the "Regular" style or co. is used.
A simple test, look at the current dir name in the Dolphin url bar with
and without ",Regular" appended to the font= entry (assuming you're using
Noto Sans or DejaVu Sans as the styleName varies from font to font).
Reviewers: #frameworks, dfaure, davidedmundson, cfeck, ervin
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27735
|
|
Summary:
- Drop redundant args to startElement()/endEelement()
- Use range-for
- Drop ConfigLoaderHandler methods that weren't used anywhere AFAICS
and ConfigLoaderHandler is private API
Test Plan: make && ctest
Reviewers: #frameworks, apol, dfaure
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27157
|
|
Summary: QXmlInputSource is deprecated in qt5.15
Test Plan: autotest ok
Reviewers: dfaure, apol
Reviewed By: apol
Subscribers: apol, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D26890
|
|
cgit.kde.org may go away at a certain point,
while commits.kde.org is meant to stay around.
|
|
|
|
GIT_SILENT
|
|
Summary:
This allows manually invoking session restoration logic without creating duplicate
configs, in support of D25106 and https://invent.kde.org/kde/okular/merge_requests/58/
Test Plan: Apply either of the above patches and verify that it works
Reviewers: #frameworks, davidedmundson
Reviewed By: davidedmundson
Subscribers: anthonyfieroni, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D25219
|
|
GIT_SILENT
|
|
Summary:
Allows
* projects linking to KConfigCore/Gui to hide deprecated API up to a
given version or silence deprecation warnings after a given version,
using
* -DKCONFIGCORE_DISABLE_DEPRECATED_BEFORE_AND_AT
* -DKCONFIGCORE_NO_DEPRECATED
* -DKCONFIGCORE_DEPRECATED_WARNINGS_SINCE
* -DKCONFIGCORE_NO_DEPRECATED_WARNINGS
* -DKCONFIGGUI_DISABLE_DEPRECATED_BEFORE_AND_AT
* -DKCONFIGGUI_NO_DEPRECATED
* -DKCONFIGGUI_DEPRECATED_WARNINGS_SINCE
* -DKCONFIGGUI_NO_DEPRECATED_WARNINGS
or
* -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
* -DKF_NO_DEPRECATED
* -DKF_DEPRECATED_WARNINGS_SINCE
* -DKF_NO_DEPRECATED_WARNINGS
* to build KConfigCore/Gui optionally with deprecated API excluded from
the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.
Test Plan:
Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.0.0, 5.0.0,
5.11.0, 5.24.0, 5.39.0, 5.42.0, CURRENT.
Reviewers: #frameworks, mlaurent
Reviewed By: mlaurent
Subscribers: mlaurent, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24496
|
|
|
|
Reviewers: apol
Reviewed By: apol
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24398
|
|
Summary: suggested by clang-tidy
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24312
|
|
GIT_SILENT
|
|
GIT_SILENT
|
|
Summary: compile without foreach
Test Plan: Unittest Ok as previously
Reviewers: dfaure
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19326
|
|
Summary:
Removing the (typically empty) optional argument from the function
invocation avoids confusion and allows to remove the parameter.
See also D15558
Test Plan: make
Reviewers: #frameworks, apol
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15848
|
|
|
|
Summary:
Default shortcuts for zoom in ({key Ctrl +}) and out ({key Ctrl -})
already exists but not for going back to 100%.
The shortcut {key Ctrl 0} is widely used by different applications
for zoom to original size. This patch adds {key Ctrl 0} as system
default for `KStandardAction::ActualSize`.
FEATURE: 305702
FIXED-IN: 5.50
Test Plan:
Searched lxr for conflicts of `KStandardAction::ActualSize` and
usage of Ctrl+0 shortcut.
Checked the following applications with set system default shortcut:
* Gwenview
* KAlgebra
* KolourPaint
* KStars (FITS viewer)
* Cirkuit
Only Cirkuit uses Ctrl+0 for "Zoom To Fit" action. I'll create a
patch to solve this conflict.
Reviewers: dfaure, broulik, ngraham, rkflx
Reviewed By: dfaure, ngraham, rkflx
Subscribers: jriddell, rkflx, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14201
|
|
|
|
|
|
|
|
Summary: FEATURE: Use Ctrl+Shift+, as the standard keyboard shortcut to invoke KDE programs' "Configure <Program>" menu items.
Test Plan:
This shortcut is not used by anything else. Searched on lxr, found one conflict in DigiKam, and the developers agreed to change it: https://bugs.kde.org/show_bug.cgi?id=386335
Will wait to land this until Digikam 5.8.0 is released to prevent any shortcut conflicts.
Tested in KDE Neon. Tried out Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, and Skanlite; all now have a consistent keyboard shortcut for their "Configure <Program>" menu items.
Reviewers: #frameworks, #vdg, broulik, rkflx
Reviewed By: rkflx
Subscribers: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8296
|
|
|
|
|
|
Qt doesn't make it easy for us to just use QWindow...
|
|
For consistency with D7293.
Differential Revision: https://phabricator.kde.org/D7758
|
|
Differential Revision: https://phabricator.kde.org/D7605
|
|
For consistency with D6774.
CCBUG: 382450
Differential Revision: https://phabricator.kde.org/D6775
|
|
Summary:
This is particularly useful for cross-compilation, where we only need the
kconfig_compiler on the host system.
Reviewers: #frameworks, apol, aacid
Reviewed By: aacid
Subscribers: aacid
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6994
|
|
Summary:
This is what other webbrowsers like Firefox and Chrome do,
and is certainly much more international than Ctrl+Comma/Ctrl+Dot which
is very qwerty centric.
Test Plan: Switching tabs in Konqueror
Reviewers: mdawson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6553
|
|
Using the new extra-cmake-modules module ECMAddQch (since 5.36.0)
this adds the option to automatically build and install a file
in QCH format with the docs about the public API, which then can be
used e.g. in Qt Assistant, Qt Creator or KDevelop.
Additionally the installed cmake config files will be extended
with a target KF5Config_QCH containing information about how to "link"
into the generated QCH file, which then can be used in the cmake build
system of other libraries building on this library, by
simply listing this target in "LINK_QCHS" of their ecm_add_qch() usage.
And a respective doxygen tag file with all the metadata about the
generated QCH file and used for the "linking" will be created and
installed.
Pass -DBUILD_QCH=ON to cmake to enable this.
|
|
|
|
For some reason some people have kdeglobals entries like
Close=Ctrl+W; Ctrl+Esc; Ctrl+W; Ctrl+Esc;
having the same shortcut more than once in the shortcut declaration is clearly bogus so fix it
BUGS: 375555
REVIEW: 129987
|
|
|
|
Differential Revision: https://phabricator.kde.org/D3987
|
|
|
|
|
|
REVIEW: 128608
CHANGELOG: Add Donate entry to KStandardShortcut
|
|
REVIEW: 128517
|
|
No one could be using this because they would not be able to link,
|
|
This way it can be shown in the apidox.
|
|
|