Age | Commit message (Collapse) | Author |
|
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
We require Qt 5.8
|
|
|
|
Test Plan: tests pass
Reviewers: #frameworks, markg
Reviewed By: markg
Subscribers: markg
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D10771
|
|
Summary:
The SortOrder key is deprecated by the Desktop Entry Specification:
https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
Reviewers: dfaure, #frameworks
Reviewed By: dfaure
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D9224
|
|
Summary:
KDesktopFile::sortOrder() returns the value of SortOrder key
as a string whithout parsing it as a list.
But according to Desktop Entry Specification
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
it's type is "string(s)", i.e. the same type as the type of
Actions and MimeType keys, and thus it should be read the same way.
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Subscribers: dfaure, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8689
|
|
|
|
|
|
Summary:
Every time we open a configuration file, we are checking if this file is there.
Since it's a sysadmin setting I'd say it's fine to assume that it's not appearing
and disappearing.
Also we are not supporting the case of the file changing during runtime or so.
Reviewers: #frameworks, mpyne, dfaure
Reviewed By: mpyne, dfaure
Subscribers: dfaure, mpyne
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8871
|
|
Using initializer_lists for QList we reserve the right amount of memory in advance and also make for nicer code.
Also uses range-for where code was touched and a const container used.
Differential Revision: https://phabricator.kde.org/D7879
|
|
As per the Desktop Entry spec, we strip trailing whitespace from the key
when we split an entry into a key/value pair at the '='. Now we also
strip leading whitespace from the resulting value like we should.
CCBUG:310674
Differential Revision: https://phabricator.kde.org/D7169
|
|
Differential Revision: https://phabricator.kde.org/D7210
|
|
Summary:
This is particularly useful for cross-compilation, where we only need the
kconfig_compiler on the host system.
Reviewers: #frameworks, apol, aacid
Reviewed By: aacid
Subscribers: aacid
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6994
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Using the new extra-cmake-modules module ECMAddQch (since 5.36.0)
this adds the option to automatically build and install a file
in QCH format with the docs about the public API, which then can be
used e.g. in Qt Assistant, Qt Creator or KDevelop.
Additionally the installed cmake config files will be extended
with a target KF5Config_QCH containing information about how to "link"
into the generated QCH file, which then can be used in the cmake build
system of other libraries building on this library, by
simply listing this target in "LINK_QCHS" of their ecm_add_qch() usage.
And a respective doxygen tag file with all the metadata about the
generated QCH file and used for the "linking" will be created and
installed.
Pass -DBUILD_QCH=ON to cmake to enable this.
|
|
|
|
The "dir" and "path" variables were obviously swapped here by mistake.
This resulted in the relativePath always being empty, and made the
function return "~/.local/share/" (or "~/.config/") instead of the
correct path.
BUG: 345100
FIXED-IN: 5.34.0
Differential Revision: https://phabricator.kde.org/D5502
|
|
Spotted because it leads to race conditions due to tzset
(surely a Qt bug, but anyway no point in finding out lastModified
for nothing).
While at it, remove the unused size field as well.
|
|
clarity.
|
|
Differential Revision: https://phabricator.kde.org/D4941
|
|
Summary:
It can't possibly have been used anywhere, because it's not in the KConfig
API anywhere. The intended way to use this API was by providing a plugin
that would derive from KConfigBackend but the plugin loading code
in KConfigBackend::create has been disabled since before KF 5.0.
The reason I want to stop exporting this class is to be able to
optimize it (e.g. the QDateTime in it is completely unused but leads
to data races due to tzset)
Test Plan: Note, I'll rename it to _p.h if we agree, it would just have made this diff too big.
Reviewers: mdawson
Reviewed By: mdawson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D4604
|
|
Even with 5.8 we need it, not due to QLockFile, but just due to mainConfigName(),
see unittest ksharedconfig_in_global_object
|
|
It's not needed, this is purely a test for the standalone KEntryMap class.
|
|
It is internal.
|
|
|
|
Differential Revision: https://phabricator.kde.org/D3987
|
|
|
|
|
|
|
|
|
|
REVIEW: 129745
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty()
Reviewers: #frameworks, sebas, sitter
Reviewed By: sebas, sitter
Differential Revision: https://phabricator.kde.org/D3314
|
|
|
|
|
|
Don't drop the file: prefix twice in every run.
Use appropriate API on paths rather than string handling, when possible.
REVIEW: 127813
|
|
CCMAIL: elvis.angelaccio@kdemail.net
|
|
REVIEW: 128023
|
|
Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
entry we would skip the KAuthorized check. This is clearly wrong.
REVIEW: 127948
|
|
The typedef is copied here to avoid including the header that contains
it. However, this confuses sip if binding definitions are generated
from the C++ headers. Simply inline the typedef instead.
|
|
|
|
Just keep the setting once and always use QString::compare instead of
using QString::operator== or QString::compare depending on the platform.
|
|
|
|
|
|
Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.
REVIEW: 127462
CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
|
|
Differential Revision: https://phabricator.kde.org/D990
|