Age | Commit message (Collapse) | Author |
|
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts
REVIEW: 118666
|
|
According to http://qt-project.org/doc/qt-5/qvariant.html#type the
return value of QVariant::type() should be interpreted as a
QMetaType::Type.
This also silences the compile-time warnings about 38 not being a member
of QVariant::Type.
REVIEW: 118332
|
|
Simplify KConfigGroup::readEntry/writeEntry.
KConfigGroup::readCheck/writeCheck caused some compilers to complain
since they were private functions that were being reimplemented outside
the class definition.
Updated KCONFIGGROUP_DECLARE_ENUM_QOBJECT/
deprecated global functions created in KDE4 times.
|
|
/home/scripty/prod/git-unstable/frameworks_kconfig/src/core/bufferfragment_p.h:37: Ignoring definition of undeclared qualified class
/home/scripty/prod/git-unstable/frameworks_kconfig/src/core/bufferfragment_p.h:37: Ignoring definition of undeclared qualified class
|
|
This reverts commit 625e124898afad04ab5c3939b1b129b6014046cd.
Let's take the time to think about a better solution, possibly.
|
|
Only KSharedConfig::openConfig() and KConfig default constructor are affected.
KConfig("kdeglobals"), for instance, points to ~/.config so that it can be shared.
REVIEW: 117989
|
|
kconfigini.cpp:554: Class 'KConfigIniBackend' lacks Q_OBJECT macro
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
kde5/services is kservices5
kde5/servicetypes is kservicestypes5
|
|
This is instead of INCLUDE_INSTALL_DIR and INSTALL_TARGETS_DEFAULT_ARGS,
which will lose the "KF5" suffix from the include path.
|
|
A lot of kiosk stuff is actually in other frameworks, from the point of
view of applications, but KConfig provides the core functionality. Make
the docs here describe KConfig's role, rather than KIO's or KXMLGui's.
REVIEW: 117486
|
|
http://standards.freedesktop.org/desktop-entry-spec/1.1/ar01s03.html
|
|
|
|
|
|
|
|
The extra load of values in KCoreConfigSkeleton is not documented anywhere
that it happens, and in normal circumstances re-loading new values isn't
expecterd during a save operation.
Update various mentions of readConfig/writeConfig to read/save.
Update documentation to match the new names of functions.
Rename writeConfig() to save() and usrWriteConfig() to usrSave()
Rename functions to match the new naming conventions. Also create old deprecated
instances of both functions to ensure that old code continues to operate
correctly. Also make save() non-virtual, for the same reasons read() is
now non-virtual.
Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig.
Rename usrReadConfig to usrRead, and mark the former as deprecated. To maintain
compatibility, usrRead still calls usrReadConfig in its default implementation.
usrReadConfig remains empty.
REVIEW: 117010
|
|
It is not on $PATH, so we cannot just expect QProcess to find it.
REVIEW: 117023
|
|
LXR suggests nothing still sets that (everything is X-DocPath now).
REVIEW: 117003
|
|
The fact that it changed in KDE 4.3 is not so relevant any more.
REVIEW: 116962
|
|
REVIEW: 116962
|
|
All this ifdef'd-out code just makes it hard to see what's going on.
REVIEW: 116962
|
|
As discussed with Matthew Dawson in review 116461.
|
|
|
|
Apps can reimplement usrReadConfig() or the readConfig() in every item instead.
|
|
|
|
Call it from generated singletons, since the constructor creates
a KConfig from a filename, which already loads from disk.
This removes the need for using DelayedParsing.
REVIEW: 116845
|
|
|
|
|
|
|
|
|
|
kdeplatformtheme would load kdeglobals and the app config file, in order
to load settings, before the unittests get a chance to call
QStandardPaths::setTestModeEnabled(true). As a result, the test would
keep getting references to "wrong" shared config objects, pointing to
the real user's locations rather than the test directories.
This fixes e.g. kconfigdialog_unittest from kconfigwidgets for me
(it only passes on build.kde.org because it doesn't install frameworkintegration
for testing this framework)
REVIEW: 115963
|
|
returned by config().
This is useful when using kconfigxt and some other code to read from the same
config file (e.g. KColorScheme::contrastF(config)) - no need to call KSharedConfig::openConfig
twice, just grab the KSharedConfig from the generated class.
REVIEW: 115960
|
|
Previously the classes generated by kconfig_compiler would only emit
the defined signals when using the setters provided by that class.
However, when using e.g. KConfigDialog which uses
KConfigSkeletonItem::setProperty() to change the items no signal was
generated.
This patch fixes this by using a wrapper KConfigSkeletonItem
subclass that calls a private itemChanged() method in the generated
class which updates the set of changed properties. As soon as the item
is saved (usrWriteConfig() in the generated class is called) the signal
will be emitted
REVIEW: 115635
REVIEW: 115634
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|