| Age | Commit message (Collapse) | Author |
|---|
|
Test Plan: tests pass
Reviewers: #frameworks, markg
Reviewed By: markg
Subscribers: markg
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D10771
|
|
|
|
Summary:
Every time we open a configuration file, we are checking if this file is there.
Since it's a sysadmin setting I'd say it's fine to assume that it's not appearing
and disappearing.
Also we are not supporting the case of the file changing during runtime or so.
Reviewers: #frameworks, mpyne, dfaure
Reviewed By: mpyne, dfaure
Subscribers: dfaure, mpyne
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8871
|
|
clarity.
|
|
Even with 5.8 we need it, not due to QLockFile, but just due to mainConfigName(),
see unittest ksharedconfig_in_global_object
|
|
|
|
Differential Revision: https://phabricator.kde.org/D3987
|
|
|
|
Just keep the setting once and always use QString::compare instead of
using QString::operator== or QString::compare depending on the platform.
|
|
Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.
REVIEW: 127462
CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
|
|
Fallback will be :/kconfig/
REVIEW: 125598
|
|
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods
Compiles, test pass
REVIEW: 125106
|
|
|
|
It's called a lot at startup as shown by profiling.
heaptrack also complains it does many heap allocations, so cache it.
REVIEW: 124199
|
|
ksharedconfig_in_global_object.cpp is now in kdelibs4 too
(where it works) and reproduces Albert's KgDifficulty testcase.
CHANGELOG: fix assert when using KSharedConfig in a global object destructor.
REVIEW: 122232
|
|
The local config file gets locked on line 415, if we return early we
need to unlock it.
REVIEW: 122549
BUG: 344032
|
|
|
|
KConfig fails building because QBasicAtomicInt is being treated as an int.
REVIEW: 119417
|
|
|
|
This fixes a regression introduced in
988f09bb051dca0437ecec431ee44ed5b4a560d8.
The mentioned commit ensures that if the locale is e.g. "de_DE" the
entry "de" will be used. But this breaks if there is a translation
for another country. E.g. for "de_CH" it would also pick the "de"
entry.
This change now operates on both just the language code and the locale.
If an entry with the language code is present it will be picked. If
another entry with the exact locale is found it will be overwritten.
Modifiers are not supported as this is currently missing in QLocale.
REVIEW: 118692
|
|
Before, these kind of read-only operations did a lot of allocations:
1) allocate a list of all sub groups
2) for the above, also allocate a sub-group match key
3) iterate over sub groups, allocate a list of all keys in there
and then finally check whether that list is non-empty
All of the above is now done without a single allocation, by simply
iterating over the list of entries.
Note: The whole list was iterated even before in allSubGroups. Now
we still do that, but check for non-empty keys in the group or
sub group directly. Much more efficient.
Note2: While at it, allSubGroups is also optimized to not require the
allocation of the subgroup match key.
REVIEW: 118586
forward-port of commit eaffd50adfd7fcbeafadb0248904176808b4499d
|
|
forward-port of commit 416559cdb86f9cacf4ea4ed7530cbbbdb427302f
|
|
The underlying KConfig used QLocale::name() for getting the locale
aware part. But this returns "de_DE" while the desktop files store
"de".
In addition it constructs a QLocale object instead of using the
system locale. This has the advantage that the usage of
QLocale::setDafault() gets honored by KConfig.
REVIEW: 118564
|
|
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts
REVIEW: 118666
|
|
This reverts commit 625e124898afad04ab5c3939b1b129b6014046cd.
Let's take the time to think about a better solution, possibly.
|
|
Only KSharedConfig::openConfig() and KConfig default constructor are affected.
KConfig("kdeglobals"), for instance, points to ~/.config so that it can be shared.
REVIEW: 117989
|
|
|
|
It is not on $PATH, so we cannot just expect QProcess to find it.
REVIEW: 117023
|
|
All this ifdef'd-out code just makes it hard to see what's going on.
REVIEW: 116962
|
|
|
|
|
|
|
|
|
|
|
|
Use git blame -w 867e7a5 to show authorship as it was before this commit.
|
|
|
