aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-15Now that kconfigbackend.h isn't installed anymore, rename it to _p.h for ↵David Faure
clarity.
2017-03-11Upgrade KF5 version to 5.33.0.l10n daemon script
2017-03-06Sanitize shortcut list on read/write from kdeglobalsAlbert Astals Cid
For some reason some people have kdeglobals entries like Close=Ctrl+W; Ctrl+Esc; Ctrl+W; Ctrl+Esc; having the same shortcut more than once in the shortcut declaration is clearly bogus so fix it BUGS: 375555 REVIEW: 129987
2017-03-05avoid useless reallocs by removing squeeze call on temporary bufferChristoph Cullmann
Differential Revision: https://phabricator.kde.org/D4941
2017-03-03Upgrade ECM and KF5 version requirements for 5.32.0 release.l10n daemon script
2017-02-21KConfig: stop exporting and installing KConfigBackend.David Faure
Summary: It can't possibly have been used anywhere, because it's not in the KConfig API anywhere. The intended way to use this API was by providing a plugin that would derive from KConfigBackend but the plugin loading code in KConfigBackend::create has been disabled since before KF 5.0. The reason I want to stop exporting this class is to be able to optimize it (e.g. the QDateTime in it is completely unused but leads to data races due to tzset) Test Plan: Note, I'll rename it to _p.h if we agree, it would just have made this diff too big. Reviewers: mdawson Reviewed By: mdawson Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D4604
2017-02-14GIT_SILENT remove comment about this being a temp workaround.David Faure
Even with 5.8 we need it, not due to QLockFile, but just due to mainConfigName(), see unittest ksharedconfig_in_global_object
2017-02-11Upgrade KF5 version to 5.32.0.l10n daemon script
2017-02-04Upgrade ECM and KF5 version requirements for 5.31.0 release.l10n daemon script
2017-02-04Fix linking on Windows: don't link kentrymaptest to KConfigCore.David Faure
It's not needed, this is purely a test for the standalone KEntryMap class.
2017-02-04Don't export KEntryMapStephen Kelly
It is internal.
2017-02-04Don't link against kconfigdata.cpp in the kentrymaptest unit test.Matthew Dawson
Due to eab822e206207c51d47f0f0da109caacfbee4e2f, KEntryMap is now an exported type. As such it is no longer needed to link in kconfigdata.cpp into this test.
2017-02-02Upgrade Qt5 version requirement to 5.6.0.l10n daemon script
2017-01-16Prefer nullptr over Q_NULLPTRKevin Funk
2017-01-16Use nullptr everywhereKevin Funk
Differential Revision: https://phabricator.kde.org/D3987
2017-01-16Fix a few -Wdocumentation warningsKevin Funk
2017-01-15Add python bindingsStephen Kelly
2017-01-15Add missing export decorationStephen Kelly
2017-01-14Upgrade KF5 version to 5.31.0.l10n daemon script
2017-01-09autotest: add expected failure with Qt 5.8.0, with runtime check.David Faure
+ simplify using recursive-remove and testmode.
2017-01-08Update message, kdeui doesn't exist anymore.David Faure
2017-01-08This should now use nullptrDavid Faure
2017-01-08Upgrade ECM and KF5 version requirements for 5.30.0 release.l10n daemon script
2017-01-06Generate an instance with KSharedConfig::Ptr for singleton and argMartin Gräßlin
Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. The change is source-incompatible in the following situation: * kcfgfile arg="true" * Singleton = true * Inherits is specified In this situation the previous revision created an instance method with a QString argument and passed that to the parent constructor. This is not in accordance with the documentation. Any user of this behavior was relying on a bug. With this change now the call to the parent constructor carries a KSharedConfigPtr. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks, dfaure, mdawson Differential Revision: https://phabricator.kde.org/D3690
2017-01-04GIT_SILENT add missing include(CMakeFindDependencyMacro)Sven Brauch
2017-01-03GIT_SILENT Fix ECM warning: use CMakePackageConfigHelpers instead of ECM variantSven Brauch
2017-01-03Fix build with CMP 0026 set to NEWSven Brauch
2017-01-03Fix build with CMP0048 set to NEWSven Brauch
2017-01-03Require CMake 3.0, as discussed on kde-frameworks-develSven Brauch
2017-01-02Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAGAlbert Astals Cid
REVIEW: 129745
2016-12-21SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-12-20SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2016-12-17[kconfig_compiler] Improve documentation about InheritsMartin Gräßlin
Summary: Better specify the requirements the parent class needs to have. KConfigCompiler generates different variants of ctors taking either: * a QStringLiteral argument (name set in <kcfgfile> * a KSharedConfig::Ptr argument (arg="true" in <kcfgfile>) * no argument (Inherits=true in kcfgc and no <kcfgfile>) In order to have Inherits generate compiling code in all cases the parent class needs to provide accessible ctors. This change updates the docuementation to reflect this. Reviewers: #frameworks, dfaure Differential Revision: https://phabricator.kde.org/D3636
2016-12-16kconfig_compiler: Use nullptr in generated codeKevin Funk
Reviewers: #frameworks, davidedmundson Reviewed By: davidedmundson Differential Revision: https://phabricator.kde.org/D3702
2016-12-12Upgrade KF5 version to 5.30.0.l10n daemon script
2016-12-07Revert "Generate an instance with KSharedConfig::Ptr for singleton and arg"David Faure
This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839. As suggested by Martin on release-team@kde.org, given that it breaks SC.
2016-12-07Revert "[autotest] Fix stupidity"David Faure
This reverts commit 71f16741a0288d8587876dcc7dbb33ba8f00546a.
2016-12-03Upgrade ECM and KF5 version requirements for 5.29.0 release.l10n daemon script
2016-12-02[autotest] Fix stupidityMartin Gräßlin
Sorry.
2016-12-02Generate an instance with KSharedConfig::Ptr for singleton and argMartin Gräßlin
Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. This provides full API compatibility and at the same time allows to use KSharedConfig in addition to the arg name based variant. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks Differential Revision: https://phabricator.kde.org/D3386
2016-11-23Add FreeBSD to metainfo.yaml.Tobias C. Berner
REVIEW: 129450
2016-11-17Properly test environment variableAleix Pol
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty() Reviewers: #frameworks, sebas, sitter Reviewed By: sebas, sitter Differential Revision: https://phabricator.kde.org/D3314
2016-11-15Upgrade KF5 version to 5.29.0.l10n daemon script
2016-11-12kconfig_compiler - generate code with overridesAllen Winter
REVIEW: 129382
2016-11-10src/core/kconfigbackend.cpp - handle unused 'sys' argumentAllen Winter
2016-11-07Make sure we don't break compilation with past broken unitsAleix Pol
Summary: Show a warning together with the old broken behavior Reviewers: #frameworks, dfaure Reviewed By: dfaure Differential Revision: https://phabricator.kde.org/D3287
2016-11-07Properly parse function keywordsAleix Pol
Summary: Use cmake_parse_arguments() instead of roughly implementing it locally CCBUG: 371562 Test Plan: recompiled everything, nothing broke Reviewers: #frameworks, dfaure Reviewed By: dfaure Differential Revision: https://phabricator.kde.org/D3251
2016-11-05Upgrade ECM and KF5 version requirements for 5.28.0 release.l10n daemon script
2016-11-03Don't be fatal on File field not being properly parsedAleix Pol
Summary: Fallback on trying the same filename as the actual file. There were some regressions due to the former matching expression: string(REGEX REPLACE "^(.*\n)?File=([^\n]+kcfg).*\n.*$" "\\2" _kcfg_FILENAME "${_contents}") This one would allow for the File field to be the kcfgc file (which doesn't make sense). With this patch we're not reproducing this behaviour, but we're allowing for the things that aren't building to work. After all, most kcfg and kcfgc files share the same name. Reviewers: #frameworks, davidedmundson Reviewed By: davidedmundson Subscribers: aacid, kfunk Differential Revision: https://phabricator.kde.org/D3226
2016-10-31Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILESAleix Pol
Summary: Instead of having an odd fake of it. Will help some required refactorings and already showed some issues, fixed by this patch, namely: - don't use string(regex replace) to extract a string from another string. in case it doesn't match it will offer the whole content which is never what we want. - messages(ERROR), the correct parameter is FATAL_ERROR, cmake understands "ERROR" as mere output string - turn the macro into a function, otherwise 2 calls in the same subdirectory are dangerous. CCBUG: 371562 Test Plan: tests still pass, projects that use the macro still build Reviewers: #frameworks, dfaure Reviewed By: dfaure Subscribers: dfaure Differential Revision: https://phabricator.kde.org/D3178