Age | Commit message (Collapse) | Author |
|
|
|
|
|
These fields should all be written to before they are read during normal
operation, but this ensures they have a sensible default in case they are not.
Coverity issue 1291513.
|
|
This seems to be left over from KDE 3.5 times, and isn't referenced anywhere
in the code. Since its a private header, just remove.
Found by Coverity, issue 1175531.
REVIEW: 126555
|
|
During a kconf_update run, an invalid group name may be treated as correct
even though the name failed to unescape. This leads the group name to be
a null character, which will fail.
If the unescape failed, return that failure status instead. This should have
no impact, as the previous result would have been wrong anyways. Now a
more useful diagnostic will be returned instead.
Update the unit tests to ensure this issue is tested in the future.
Found in Coverity issue 258087.
REVIEW: 126556
|
|
This has been around for a long time, no need to dupilcate.
Coverity issue 1289077.
|
|
This way it can be shown in the apidox.
|
|
|
|
|
|
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Due to https://codereview.qt-project.org/#/c/106473/, Qt 5.6 keeps null
characters in QByteArray -> QString conversions, which breaks this test as
one QByteArray contains nulls. Instead, convert the QByteArray to const
char * first, so QString stops at the first null.
The actual behaviour of KConfig is unchanged, as internally the conversion
always went through a const char *, which avoids creating QStrings with
null characters.
REVIEW: 126001
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Generate-source-file macros should be used from the same CMakeLists.txt
file as the targets they generate files for.
|
|
REVIEW: 125833
|
|
|
|
|
|
Fallback will be :/kconfig/
REVIEW: 125598
|
|
|
|
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods
Compiles, test pass
REVIEW: 125106
|
|
|
|
Makes sure that it doens't create an app bundle on Mac OS X
REVIEW: 125337
|
|
|
|
CHANGELOG: KDesktopFile can now read mime types specified in the MimeType field
REVIEW: 124746
|
|
|
|
Don't build error string every time
REVIEW: 124879
|
|
|
|
|
|
strings-made-from-floats/doubles.
Qt 5.5 writes out "123.567001" for 123.567f. No matter, what we want is the
roundtrip float-string-float to work, and it does.
|
|
|
|
Because it allocates memory.
REVIEW: 124717
|
|
|
|
It's called a lot at startup as shown by profiling.
heaptrack also complains it does many heap allocations, so cache it.
REVIEW: 124199
|
|
|
|
|
|
to avoid touching the user's real files
|
|
|
|
|
|
|
|
|
|
REVIEW: 124467
|
|
::usrWriteConfig is deprecated, use ::usrSave as recommended by the
documentation.
REVIEW: 124467
|
|
|
|
|
|
|
|
As recommended by Alex Merry
CCMAIL: alex.merry@kde.org
|
|
This will make it end up in a platform-dependent prefix (i.e. /usr/lib64,
/usr/lib/arm-linux-gnueabihf, etc) rather than /usr/bin, making it possible
to have different kconfig_compiler versions installed, useful for
cross-compilation.
REVIEW: 124138
|
|
In applications translations can be looked up in the globally set
translation domain, but in libraries it is necessary to link every
i18n call to the library's own translation domain. A new code
generation option TranslationDomain= is added to enable this.
It has effect only if TranslationSystem=kde is set.
Added unit tests to check generated translation calls.
CHANGELOG: New code generation option TranslationDomain=, for use with TranslationSystem=kde; normally needed in libraries.
REVIEW: 123872
|