| Age | Commit message (Collapse) | Author |
|---|
|
|
|
No impact on the rest of the test, but I was wondering if it might
break anything, better restore it just in case.
|
|
|
|
|
|
|
|
target_sources() as used internally does not take alias targets.
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
This reverts commit b3dc879e8b108c26c929bfbe551bcdf77f140e94.
This change breaks plasmashell startup and possible other apps as well.
Reverting so the root cause can be investigated without time pressure.
|
|
calling deleteGroup only deletes all entries but the group does still
exists in listGroups
this is somewhat irritating since calling exists on that group will
return false
with this patch the group does no longer exists in listGroup
|
|
-DQT_NO_FOREACH
GIT_SILENT
|
|
KF6 task: https://phabricator.kde.org/T14467
|
|
|
|
NO_CHANGELOG
|
|
QStringView has some bits of API that were only added in 5.15.2, whereas KF
requires 5.15.0.
This reverts commit 1780fb2a237af80ddc1f9cfb70cb892b53b91990.
|
|
|
|
The symbol export/visibility attribute is not standardized so far and
needs to be set by language extension attribute declaration at least
with clang & MSVC, who both support that when it appears before the
standard attribute declaration.
NO_CHANGELOG
|
|
A window that is maximized does not really have a position on screen
other then the fact that it's maximized, and writing out position data
in this case anyway will only serve to mis-position the window once
da-maximized, should KWin ever stop remembering de-maximized window
positions internally.
CCBUG: 434116
|
|
"Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
"
We need to add file extension
|
|
NO_CHANGELOG
|
|
Some methods in ConfigLoaderHandler always returned true, change them to return
void instead. Also port them to take a QStringView instead of QStringRef, this
doesn't require a lot of changes because a QStringView can be constructed from
a QStringRef.
QXmlStreamAttribute methods like value() and name() return QStringRef in Qt5
and QStringView in Qt6, "fix" the issue by using auto keyword, which works
in both cases.
QStringView::toInt() isn't efficient in Qt5 so make the build conditional.
NO_CHANGELOG
|
|
|
|
|
|
This matches the method actually does, and makes it clearer that you don't
need to do config->sync() followed by config()->reparseConfiguration(), the
latter should suffice.
|
|
|
|
Since the FSDevice .desktop template hasn't been installed for a long time,
this method in KDesktopFile hasn't been useful. The whole FSDesktop concept
seems to be redundant nowadays, since CDRom and Floppy drives have been replaced
by USB sticks.
See this KF6 taks for more details:
https://phabricator.kde.org/T14295#253759
|
|
|
|
It's internal, the symbols are not exported, the header is not installed.
The _p.h naming makes this more obvious, when grepping for stuff in
public API.
|
|
These function check for the po directory presence themselves,
and can also handle it being in the build directory with KDE_L10N_AUTO_TRANSLATIONS
NO_CHANGELOG
|
|
|
|
All named authors from copyright statements confirmed this change
(confirmations at sysadmins' longterm archive). From the git history
check, relicensecheck tells:
- lgplv2+: mdawson pandom79@gmail.com
mdawson ( 6 LOC): 0005ba7
pandom79@gmail.com ( 4 LOC): eeb2bbe
Whereas pandom79 does not posses a KDE contributor account but also
confirmed via private mail (confirmation mail also in sysadmins'
archive).
Change 0005ba7 is a syntactical replacement of QT_TRANSLATE_NOOP with
QT_TRANSLATE_NOOP3 and thus can be assumed to not by copyrightable.
|
|
All named authors from copyright statements confirmed this change
(confirmations at sysadmins' longterm archive). From the git history
check, relicensecheck tells:
- lgplv2+: pandom79@gmail.com
pandom79@gmail.com ( 7 LOC): eeb2bbe
Whereas pandom79 does not posses a KDE contributor account but also
confirmed via private mail (confirmation mail also in sysadmins'
archive).
|
|
|
|
This fixes the clang warning
globalsettings_kmail.h:58:5: warning: '~GlobalSettingsBase' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
|
|
|
|
|
|
|
|
Relicense approved by relicensecheck except:
- lgplv2+: a.volkov@rusbitech.ru
a.volkov@rusbitech.ru ( 1 LOC): d328dd6
Which is a non-copyrightible trivial change.
|
|
In Qt6 QDomDocument does not open the file itself any more
|
|
|
|
|
|
NO_CHANGELOG
|
|
Now it creates C++ code that uses QString::arg(Args...) instead of
arg().arg().
AFAICS, the type of the "Args" is QString, so this should work.
|
|
- Use more range-for loops where appropriate
- Use auto instead of the usually-long iterator type names
- Use cbegin/cend(), to match the std:: containers, less confusion
- Use qDeleteAll instead of a for loop
- Make a QRE with a long-ish pattern static
NO_CHANGELOG
|
|
- Use QString::arg(Args...) instead of .arg().arg()
- Use QLatin1String for string comparisons, should be faster
- Use QLatin1String::arg() for better readability
- Add the comment dfaure suggested in the MR, to explain why it's '2%'
then '%1' in a QString().arg().arg()
NO_CHANGELOG
|
|
GIT_SILENT
|
|
This was missed in https://invent.kde.org/frameworks/kconfig/-/merge_requests/41
|
|
The implicit conversion fails in Qt6
|
|
|
|
GIT_SILENT
|
