| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
This matches the method actually does, and makes it clearer that you don't
need to do config->sync() followed by config()->reparseConfiguration(), the
latter should suffice.
|
|
|
|
Since the FSDevice .desktop template hasn't been installed for a long time,
this method in KDesktopFile hasn't been useful. The whole FSDesktop concept
seems to be redundant nowadays, since CDRom and Floppy drives have been replaced
by USB sticks.
See this KF6 taks for more details:
https://phabricator.kde.org/T14295#253759
|
|
|
|
It's internal, the symbols are not exported, the header is not installed.
The _p.h naming makes this more obvious, when grepping for stuff in
public API.
|
|
These function check for the po directory presence themselves,
and can also handle it being in the build directory with KDE_L10N_AUTO_TRANSLATIONS
NO_CHANGELOG
|
|
|
|
All named authors from copyright statements confirmed this change
(confirmations at sysadmins' longterm archive). From the git history
check, relicensecheck tells:
- lgplv2+: mdawson pandom79@gmail.com
mdawson ( 6 LOC): 0005ba7
pandom79@gmail.com ( 4 LOC): eeb2bbe
Whereas pandom79 does not posses a KDE contributor account but also
confirmed via private mail (confirmation mail also in sysadmins'
archive).
Change 0005ba7 is a syntactical replacement of QT_TRANSLATE_NOOP with
QT_TRANSLATE_NOOP3 and thus can be assumed to not by copyrightable.
|
|
All named authors from copyright statements confirmed this change
(confirmations at sysadmins' longterm archive). From the git history
check, relicensecheck tells:
- lgplv2+: pandom79@gmail.com
pandom79@gmail.com ( 7 LOC): eeb2bbe
Whereas pandom79 does not posses a KDE contributor account but also
confirmed via private mail (confirmation mail also in sysadmins'
archive).
|
|
|
|
This fixes the clang warning
globalsettings_kmail.h:58:5: warning: '~GlobalSettingsBase' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
|
|
|
|
|
|
|
|
Relicense approved by relicensecheck except:
- lgplv2+: a.volkov@rusbitech.ru
a.volkov@rusbitech.ru ( 1 LOC): d328dd6
Which is a non-copyrightible trivial change.
|
|
In Qt6 QDomDocument does not open the file itself any more
|
|
|
|
|
|
NO_CHANGELOG
|
|
Now it creates C++ code that uses QString::arg(Args...) instead of
arg().arg().
AFAICS, the type of the "Args" is QString, so this should work.
|
|
- Use more range-for loops where appropriate
- Use auto instead of the usually-long iterator type names
- Use cbegin/cend(), to match the std:: containers, less confusion
- Use qDeleteAll instead of a for loop
- Make a QRE with a long-ish pattern static
NO_CHANGELOG
|
|
- Use QString::arg(Args...) instead of .arg().arg()
- Use QLatin1String for string comparisons, should be faster
- Use QLatin1String::arg() for better readability
- Add the comment dfaure suggested in the MR, to explain why it's '2%'
then '%1' in a QString().arg().arg()
NO_CHANGELOG
|
|
GIT_SILENT
|
|
This was missed in https://invent.kde.org/frameworks/kconfig/-/merge_requests/41
|
|
The implicit conversion fails in Qt6
|
|
|
|
GIT_SILENT
|
|
NO_CHANGELOG
|
|
- This has the same logic as QMap::constFind(); less detaching and now we
can use auto keyword when creating iterators and always get a const_iterator
even when calling constFindEntry() on a non-const map.
- Use QCOMPARE() where appropriate in the unit tests.
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
GIT_SILENT
|
|
|
|
See https://invent.kde.org/sdk/kdesrc-build/-/merge_requests/82
GIT_SILENT
|
|
We have a fallback string that gets searched for in the KCM, but that
fallback itself should not have a fallback, or else we always use that
second fallback and the window gets positioned incorrectly the first
time it's opened. So let's replace the second fallback with -1.
BUG: 432661
FIXED-IN: 5.79
|
|
It's a QByteArray not a QString.
GIT_SILENT
|
|
I didn't consider the '#ifdef Q_OS_WIN' code paths (since that compiles
just fine locally).
GIT_SILENT
|
|
- Use a global var for a QString that's used many times
- Break up long-all-cap variable names, it makes it harder to read (and
I've fixed one typo in one of those ALLCAPS)
- Fix some clazy warnings, make global QString objects in unit tests
static (so that the compiler doesn't create symbols for them, it doesn't
matter in a unit test but KF code acts as a reference sometimes that
others copy from, tip from dfaure)
- Add TODO note about changing kconfig_compiler to generate C++ code that
uses multi-arg QString::arg(QString, QString, QString) instead of
QString::arg().arg()
- More const; more QString::at() instead of operator[] where appropriate
- Use a ternary where it makes the code more readable (and uses less lines :))
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
Fix some clazy warnings, and some other minor code optimisations.
NO_CHANGELOG
|
|
* Doxygen sections instead of markdown list items and HTML headers
* More descriptive section titles
* HTML Definition list instead of a wide HTML table for compiler options
* HTML Definition list instead of a markdown item list for data types
* Syntax highlighting for examples
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
This commit refactors the code a bit to define the window geometry
strings in one place and uses a common method to read and write them.
This makes future changes much less fragile and fixes a pre-existing bug
that had gone un-noticed which caused window positions to not be saved
on a per-resolution basis in addition to a per-display-arrangement
basis. Old strings are used if available to that people don't lose their
saved position data the first time they upgrade to KF 5.79.
|
|
The maximization string was being saved to the config file including
the connected screens, but the code to read it was not, and was also
looking for the old incorrect format. This could have resulted in old
config values being used forever, and the window always being opened
in a maximized state.
BUG: 430521
FIXED-IN: 5.79
|
|
|
