Age | Commit message (Collapse) | Author |
|
|
|
GIT_SILENT
|
|
This was missed in https://invent.kde.org/frameworks/kconfig/-/merge_requests/41
|
|
The implicit conversion fails in Qt6
|
|
|
|
GIT_SILENT
|
|
NO_CHANGELOG
|
|
- This has the same logic as QMap::constFind(); less detaching and now we
can use auto keyword when creating iterators and always get a const_iterator
even when calling constFindEntry() on a non-const map.
- Use QCOMPARE() where appropriate in the unit tests.
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
GIT_SILENT
|
|
|
|
See https://invent.kde.org/sdk/kdesrc-build/-/merge_requests/82
GIT_SILENT
|
|
We have a fallback string that gets searched for in the KCM, but that
fallback itself should not have a fallback, or else we always use that
second fallback and the window gets positioned incorrectly the first
time it's opened. So let's replace the second fallback with -1.
BUG: 432661
FIXED-IN: 5.79
|
|
It's a QByteArray not a QString.
GIT_SILENT
|
|
I didn't consider the '#ifdef Q_OS_WIN' code paths (since that compiles
just fine locally).
GIT_SILENT
|
|
- Use a global var for a QString that's used many times
- Break up long-all-cap variable names, it makes it harder to read (and
I've fixed one typo in one of those ALLCAPS)
- Fix some clazy warnings, make global QString objects in unit tests
static (so that the compiler doesn't create symbols for them, it doesn't
matter in a unit test but KF code acts as a reference sometimes that
others copy from, tip from dfaure)
- Add TODO note about changing kconfig_compiler to generate C++ code that
uses multi-arg QString::arg(QString, QString, QString) instead of
QString::arg().arg()
- More const; more QString::at() instead of operator[] where appropriate
- Use a ternary where it makes the code more readable (and uses less lines :))
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
Fix some clazy warnings, and some other minor code optimisations.
NO_CHANGELOG
|
|
* Doxygen sections instead of markdown list items and HTML headers
* More descriptive section titles
* HTML Definition list instead of a wide HTML table for compiler options
* HTML Definition list instead of a markdown item list for data types
* Syntax highlighting for examples
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
This commit refactors the code a bit to define the window geometry
strings in one place and uses a common method to read and write them.
This makes future changes much less fragile and fixes a pre-existing bug
that had gone un-noticed which caused window positions to not be saved
on a per-resolution basis in addition to a per-display-arrangement
basis. Old strings are used if available to that people don't lose their
saved position data the first time they upgrade to KF 5.79.
|
|
The maximization string was being saved to the config file including
the connected screens, but the code to read it was not, and was also
looking for the old incorrect format. This could have resulted in old
config values being used forever, and the window always being opened
in a maximized state.
BUG: 430521
FIXED-IN: 5.79
|
|
|
|
Frameworks will be Frameworks 6 at some point and there is no good reason to have the major version in the variable name.
Given this is purely internal we can to this now, making it a bit more future-proof
GIT_SILENT
NO_CHANGELOG
|
|
|
|
KDEWIN_LIBRARIES is never defined
|
|
I stored a file's lastModified() into KConfig, to compare with it
again on next start, and the loss of milliseconds made the code think
the timestamps didn't match, even when they did.
|
|
In C++20 there are new classes that have member functions named emit().
c.f.:
https://lists.qt-project.org/pipermail/development/2020-February/038812.html
https://en.cppreference.com/w/cpp/io/basic_osyncstream/emit
GIT_SILENT
|
|
In Qt6 QTextCodec/QTextStream::setCodec is replaced with
QTextStream::setEncoding(QStringConverter::Encoding)
Also UTF-8 is the new default for QTextStream.
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
Using QMutex in recursive mode is deprecated.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Forward declaring it breaks with Qt6
|
|
|
|
|
|
The latter breaks with Qt6
|
|
When a window is closed while maximized, we write a special string to
the config file so that it gets restored in its maximized state. But we
don't ever delete that thing when the window is un-maximized and closed
again, causing the window to always be maximized when launched.
BUG: 426813
FIXED-IN: 5.78
|
|
All other resolutions are stored in the form of width x height, but a
silly transposition error had the maximized strong being height x width.
That's fixed now.
|
|
The feature to make windows remember their sizes and positions across
screen layouts relied on calling QScreen::name() to identify screens.
Unfortunately this function returns garbage on Windows; see
https://bugreports.qt.io/browse/QTBUG-74317
So on Windows, let's identify displays by serial number as a workaround.
BUG: 429943
FIXED-IN: 5.78
|
|
|