aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-06GIT_SILENT Commit translations from l10n-kf5v5.63.0-rc2v5.63.0l10n daemon script
2019-10-06GIT_SILENT Upgrade ECM and KF5 version requirements for 5.63.0 release.l10n daemon script
2019-10-04Fix generating properties that start with an uppercase letterAleix Pol
Summary: We were not adjusting the property name to the getter letter-casing. Test Plan: See added test, also fixes the issue that made me realize this issue. Reviewers: #frameworks, davidedmundson Reviewed By: davidedmundson Subscribers: ngraham, aacid, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24010
2019-10-03Rewrite ugly for with pointer arithmetic into range forAlbert Astals Cid
Reviewers: apol Reviewed By: apol Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24398
2019-09-30Small performance enhacementsAlbert Astals Cid
Summary: suggested by clang-tidy Reviewers: davidedmundson Reviewed By: davidedmundson Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24312
2019-09-17[KConfig] port away from deprecated methods in Qt 5.14David Faure
Summary: In kconf_update, the ctime usage used to be about metadata change time (buff.st_ctime, before it got ported to the misnamed created()). I ported it to birthTime, because I think date of birth is a more useful way to identify a file than date of permission change which doesn't really matter to us. But in practice, I can't help but wonder if mtime alone wouldn't be enough. For the QStringLiteral("%%1").arg(i) bit, I tested it in tst_qstring, the first % is left untouched. Test Plan: make && ctest Reviewers: mdawson, arichardson, vkrause Reviewed By: vkrause Subscribers: pino, arojas, mlaurent, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D23815
2019-09-16Use new INCLUDE_DIRS with ecm_add_qch, to have doxygen see more includesFriedrich W. H. Kossebau
GIT_SILENT
2019-09-14GIT_SILENT Upgrade KF5 version to 5.63.0.l10n daemon script
2019-09-07GIT_SILENT Upgrade ECM and KF5 version requirements for 5.62.0 release.l10n daemon script
2019-08-28GIT_SILENT: use QLatin1StringLaurent Montel
2019-08-25String code optimization: use s.remove(0. x) instead of s = s.mid(x)Friedrich W. H. Kossebau
GIT_SILENT
2019-08-25String code optimization: use s.chop(x) instead of s.truncate(s.size()-x)Friedrich W. H. Kossebau
GIT_SILENT
2019-08-25Use more initializer listsFriedrich W. H. Kossebau
GIT_SILENT
2019-08-24String code optimization: use QLatin1String/QChar overload for string concatFriedrich W. H. Kossebau
GIT_SILENT
2019-08-24String code optimization: use QLatin1String overload for == & !=Friedrich W. H. Kossebau
GIT_SILENT
2019-08-24String code optimization: use QLatin1String overload for QString::replaceFriedrich W. H. Kossebau
GIT_SILENT
2019-08-22Fix memory leak in KConfigWatcherDaniel Vrátil
Reviewers: davidedmundson Reviewed By: davidedmundson Subscribers: davidedmundson, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D23340
2019-08-14Add a logging category for logs warningsMéven Car
Summary: Disable logs unless the logging category kf5.kconfig.core is enabled Test Plan: ctest Reviewers: #frameworks, apol, cgiboudeaux Reviewed By: cgiboudeaux Subscribers: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D22061
2019-08-14SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-11GIT_SILENT Upgrade KF5 version to 5.62.0.l10n daemon script
2019-08-10Disable KCONFIG_USE_DBUS on AndroidNicolas Fella
Summary: Since DBus is not available on Android we don't ever want it enabled Test Plan: Builds with simple Android cmake command Reviewers: apol, vkrause Reviewed By: vkrause Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D23062
2019-08-07Security: remove support for $(...) in config keys with [$e] marker.David Faure
Summary: It is very unclear at this point what a valid use case for this feature would possibly be. The old documentation only mentions $(hostname) as an example, which can be done with $HOSTNAME instead. Note that $(...) is still supported in Exec lines of desktop files, this does not require [$e] anyway (and actually works better without it, otherwise the $ signs need to be doubled to obey kconfig $e escaping rules...). Test Plan: ctest passes; various testcases with $(...) in desktop files, directory files, and config files, no longer execute commands. Reviewers: mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Reviewed By: mdawson, davidedmundson Subscribers: ZaWertun, rikmills, fvogt, ngraham, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D22979
2019-08-06autotests: mkpath ~/.qttest/configDavid Faure
so that the test doesn't fail after `rm -rf ~/.qttest`
2019-08-03GIT_SILENT Upgrade ECM and KF5 version requirements for 5.61.0 release.l10n daemon script
2019-08-02Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATHFriedrich W. H. Kossebau
GIT_SILENT
2019-07-20Include definition for class used in headerDavid Edmundson
2019-07-13GIT_SILENT Upgrade KF5 version to 5.61.0.l10n daemon script
2019-07-06GIT_SILENT Upgrade ECM and KF5 version requirements for 5.60.0 release.l10n daemon script
2019-07-04GIT_SILENT Upgrade Qt5 version requirement to 5.11.0.Albert Astals Cid
2019-06-08GIT_SILENT Upgrade KF5 version to 5.60.0.l10n daemon script
2019-06-01GIT_SILENT Upgrade ECM and KF5 version requirements for 5.59.0 release.l10n daemon script
2019-05-15GIT_SILENT Upgrade KF5 version to 5.59.0.l10n daemon script
2019-05-10Replace qVariantFromValue with QVariant::fromValueNicolas Fella
Summary: qVariantFromValue is obsolete (https://doc.qt.io/qt-5/qvariant-obsolete.html#qVariantFromValue-1) and causes build failure in KActivities and KEmoticons with current Qt dev Test Plan: KActivities and KEmoticons build again with current Qt dev Reviewers: #frameworks, dfaure, apol Reviewed By: apol Subscribers: apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D21107
2019-05-04GIT_SILENT Upgrade ECM and KF5 version requirements for 5.58.0 release.l10n daemon script
2019-04-24Add Notify capability to KConfigXTKai Uwe Broulik
Lets you specify Notifiers= in .kcfg for config entries that should be written with Notify flag, i.e. announce the change to KConfigWatcher Differential Revision: https://phabricator.kde.org/D20196
2019-04-13GIT_SILENT Upgrade KF5 version to 5.58.0.l10n daemon script
2019-04-07Fix typo in KConfig documentation.Jeremy Whiting
Cadcading should be cascading.
2019-04-07GIT_SILENT Upgrade ECM and KF5 version requirements for 5.57.0 release.l10n daemon script
2019-04-01Add Notify capability to revertToDefaultKai Uwe Broulik
This enables KConfigWatcher to detect those changes, too. Differential Revision: https://phabricator.kde.org/D20039
2019-03-26point readme to the wiki pageHarald Sitter
Summary: the wiki page says the readme is duplicated into the wiki. so, what we end up with is either - they end up out of sync - someone gets real angry because the wiki needs format markup while the readme must not have markup - someone doesn't get angry and simply copies either markup or nomarkup to the respectively unsuitable target it's an unsustainable situation... so instead let's point the readme to the wiki and consider that the place where the documentation is maintained Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19779
2019-03-15kconfig_compiler: new kcfgc args HeaderExtension & SourceExtensionFriedrich W. H. Kossebau
Summary: When using kconfig_compiler generated sources in projects where the used file extensions for C++ files are not ".h" and/or ".cpp", the include for the generated header looks a bit alien to the project, as well as the generated source file if one looks closer at it. This code adds new optional flags HeaderExtension & SourceExtension which can be used to control the file extensions used for the generated files. Test Plan: All unit tests and the new test_fileextensions pass, existing projects using kcfg without & with the new flags build fine. Reviewers: #frameworks, apol Reviewed By: apol Subscribers: apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19565
2019-03-12[kconf_update] move from custom logging tech to qCDebugHarald Sitter
Summary: the previous logging tech got kind of defunct in 2014 (to the point where it was basically qCDebug). seeing as no one really complained it seems reasonable to just move to qCDebug instead and make use of category filters and other qdebug goodness (such as system logging facilities for the various platforms) - new logging category kf5.kconfig.update; at info level by default (i.e. unless otherwise configured kconf_update is now silent) - --debug cmdline option now also attempts to force-enable the debug mode on that category (and debugs that attempt in of itself, so we don't get confused by categories magically getting enabled). - all log() calls are now qCDebug calls - all logFileErorr() calls (which was context-sensitive to the .upd file parsing) have been changed to qCDebugFile - qCDebugFile is a new *macro* wrapping around qCDebug to give it file context - everything is now qCDebug instead of qDebug - arguments updated to drop excess quoting and spaces to reduce "noise" https://markmail.org/thread/ofaeqcabguxyohyb Test Plan: updater still works and debugs when debug is enabled Reviewers: apol, aacid, #frameworks Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19508
2019-03-11Remove reference from const KConfigIniBackend::BufferFragment &Albert Astals Cid
Summary: According to clazy since KConfigIniBackend::BufferFragment is very small it's faster to just copy it Reviewers: apol Reviewed By: apol Subscribers: apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19666
2019-03-09GIT_SILENT Upgrade KF5 version to 5.57.0.l10n daemon script
2019-03-06KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked upFriedrich W. H. Kossebau
Summary: The build configuration depends on the value of the "File=" entry in the kcfg file, as this file name is used in the build instructions. So if the name is changed, cmake would need to be rerun. Adding the kcfgc file to CMAKE_CONFIGURE_DEPENDS makes cmake know about that dependency. While this will also result in a reconfiguarion if non-File entries are edited, this should not happen too often, so the extra costs outweighs the unexpected and confusing behaviour due to outdated build instructions in case the File= entry is changed. Test Plan: Before this change renaming a kcfg file before did not trigger a rerun of cmake, resulting in outdated builds instructions and unexpected behaviour. With this change cmake is rerun once the kcgc file is edited, so build instructions are always up-to-date. Reviewers: #frameworks, apol Reviewed By: apol Subscribers: apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19567
2019-03-04GIT_SILENT: add gitignoreLaurent Montel
2019-03-03[Kconfig] Compile without foreachLaurent Montel
Summary: compile without foreach Test Plan: Unittest Ok as previously Reviewers: dfaure Reviewed By: dfaure Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19326
2019-03-02GIT_SILENT Upgrade ECM and KF5 version requirements for 5.56.0 release.l10n daemon script
2019-03-01improve documentation on global config cascadingHarald Sitter
Summary: the previous description of IncludeGlobals was a bit lackluster. the new description should make it more obvious what the various flag permutations achieve. BUG: 306923 Reviewers: kde-frameworks-devel, apol Reviewed By: apol Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19388
2019-02-25KConfig: Assign documentation to correct enum valueThomas Fischer
Summary: In commit 8579ec54 (D13034), the Notify value got introduced in enum WriteConfigFlag in KConfigBase. When adding this new value, the value and its documentation (Doxygen format, /**<) got placed wrongly. After commit 8579ec54, the documentation for Notify "documents" the previously existing value Localized, whereas the documentation for Localized documents Notify. Simply exchanging the order of the documentation comments fixes this issue. Reviewers: broulik, dfaure, davidedmundson Reviewed By: davidedmundson Subscribers: kde-frameworks-devel Tags: documentation, frameworks Differential Revision: https://phabricator.kde.org/D19320