Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
Test Plan: tests pass
Reviewers: #frameworks, markg
Reviewed By: markg
Subscribers: markg
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D10771
|
|
Summary:
This way if another cmake project imports it when cross-compiling, it
can be executed.
Reviewers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D9652
|
|
|
|
|
|
Summary: FEATURE: Use Ctrl+Shift+, as the standard keyboard shortcut to invoke KDE programs' "Configure <Program>" menu items.
Test Plan:
This shortcut is not used by anything else. Searched on lxr, found one conflict in DigiKam, and the developers agreed to change it: https://bugs.kde.org/show_bug.cgi?id=386335
Will wait to land this until Digikam 5.8.0 is released to prevent any shortcut conflicts.
Tested in KDE Neon. Tried out Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, and Skanlite; all now have a consistent keyboard shortcut for their "Configure <Program>" menu items.
Reviewers: #frameworks, #vdg, broulik, rkflx
Reviewed By: rkflx
Subscribers: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8296
|
|
|
|
|
|
Test Plan: compile kmail without cmake warning
Reviewers: kfunk, dfaure
Reviewed By: kfunk
Subscribers: mpyne, apol, aacid, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D9277
|
|
|
|
|
|
|
|
Qt doesn't make it easy for us to just use QWindow...
|
|
Summary:
The SortOrder key is deprecated by the Desktop Entry Specification:
https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
Reviewers: dfaure, #frameworks
Reviewed By: dfaure
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D9224
|
|
Summary:
KDesktopFile::sortOrder() returns the value of SortOrder key
as a string whithout parsing it as a list.
But according to Desktop Entry Specification
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
it's type is "string(s)", i.e. the same type as the type of
Actions and MimeType keys, and thus it should be read the same way.
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Subscribers: dfaure, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8689
|
|
|
|
Summary:
The CI has $HOME=/home/jenkins/ with a trailing slash, which leads to
FAIL! : KConfigTest::testPath() Compared values are not the same
Actual (sc3.readPathEntry("homepath", QString())): "/home/jenkins//foo"
Expected (HOMEPATH): "/home/jenkins/foo"
QDir::homePath() is too clean for our purposes, use $HOME on Unix.
Test Plan:
kconfigtest now passes with HOME=/home/dfaure/
|
|
|
|
QStringLiteral is latin1, not utf8.
|
|
|
|
|
|
Summary:
Every time we open a configuration file, we are checking if this file is there.
Since it's a sysadmin setting I'd say it's fine to assume that it's not appearing
and disappearing.
Also we are not supporting the case of the file changing during runtime or so.
Reviewers: #frameworks, mpyne, dfaure
Reviewed By: mpyne, dfaure
Subscribers: dfaure, mpyne
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8871
|
|
|
|
|
|
|
|
Summary: We will be using an external version of it in practice
Reviewers: #frameworks, davidedmundson
Reviewed By: davidedmundson
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8457
|
|
|
|
Using initializer_lists for QList we reserve the right amount of memory in advance and also make for nicer code.
Also uses range-for where code was touched and a const container used.
Differential Revision: https://phabricator.kde.org/D7879
|
|
For consistency with D7293.
Differential Revision: https://phabricator.kde.org/D7758
|
|
|
|
Differential Revision: https://phabricator.kde.org/D7605
|
|
|
|
|
|
For consistency with D6774.
CCBUG: 382450
Differential Revision: https://phabricator.kde.org/D6775
|
|
As per the Desktop Entry spec, we strip trailing whitespace from the key
when we split an entry into a key/value pair at the '='. Now we also
strip leading whitespace from the resulting value like we should.
CCBUG:310674
Differential Revision: https://phabricator.kde.org/D7169
|
|
Differential Revision: https://phabricator.kde.org/D7210
|
|
|
|
|
|
Summary:
This is particularly useful for cross-compilation, where we only need the
kconfig_compiler on the host system.
Reviewers: #frameworks, apol, aacid
Reviewed By: aacid
Subscribers: aacid
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6994
|
|
1) some of them can't run in parallel
2) kconfigskeletontest failed due to KSharedConfig being used under the
scene (for a year now), and there's probably some QPA or widget style
holding a ref (here, not in the CI). Indirectly, simply setting
QStandardPaths::setTestModeEnabled(true) fixes this since KSharedConfig
will then not share the instance with the non-test-mode-enabled instance.
|
|
Summary:
This is what other webbrowsers like Firefox and Chrome do,
and is certainly much more international than Ctrl+Comma/Ctrl+Dot which
is very qwerty centric.
Test Plan: Switching tabs in Konqueror
Reviewers: mdawson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6553
|
|
|
|
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
|
|
AUTOMOC now applies to generated headers too, so we need to skip it
when using qt5_generate_moc.
|