Age | Commit message (Collapse) | Author |
|
|
|
This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839.
As suggested by Martin on release-team@kde.org, given that it breaks SC.
|
|
This reverts commit 71f16741a0288d8587876dcc7dbb33ba8f00546a.
|
|
|
|
|
|
Sorry.
|
|
Summary:
In case a kcfg with arg="true" was used and singleton the static
instance method only accepted a QString config name. This made it
impossible to combine a singleton config with an already existing and
open KSharedConfig::Ptr.
With this change an overloaded instance method is added which takes a
KSharedConfig::Ptr as argument. The private ctor, though, only takes a
KSharedConfig::Ptr and the instance method taking a QString argument
uses KSharedConfig::openConfig on the config file name.
This provides full API compatibility and at the same time allows to use
KSharedConfig in addition to the arg name based variant.
Test Plan:
kconfigcompiler tests still pass and a config with singleton
and arg="true" generates the code as I need it
Reviewers: #frameworks
Differential Revision: https://phabricator.kde.org/D3386
|
|
REVIEW: 129450
|
|
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty()
Reviewers: #frameworks, sebas, sitter
Reviewed By: sebas, sitter
Differential Revision: https://phabricator.kde.org/D3314
|
|
|
|
REVIEW: 129382
|
|
|
|
Summary: Show a warning together with the old broken behavior
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Differential Revision: https://phabricator.kde.org/D3287
|
|
Summary:
Use cmake_parse_arguments() instead of roughly implementing it locally
CCBUG: 371562
Test Plan: recompiled everything, nothing broke
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Differential Revision: https://phabricator.kde.org/D3251
|
|
|
|
Summary:
Fallback on trying the same filename as the actual file.
There were some regressions due to the former matching expression:
string(REGEX REPLACE "^(.*\n)?File=([^\n]+kcfg).*\n.*$" "\\2" _kcfg_FILENAME "${_contents}")
This one would allow for the File field to be the kcfgc file (which doesn't
make sense).
With this patch we're not reproducing this behaviour, but we're allowing for the
things that aren't building to work. After all, most kcfg and kcfgc files share
the same name.
Reviewers: #frameworks, davidedmundson
Reviewed By: davidedmundson
Subscribers: aacid, kfunk
Differential Revision: https://phabricator.kde.org/D3226
|
|
Summary:
Instead of having an odd fake of it. Will help some required
refactorings and already showed some issues, fixed by this patch,
namely:
- don't use string(regex replace) to extract a string from another
string. in case it doesn't match it will offer the whole content which
is never what we want.
- messages(ERROR), the correct parameter is FATAL_ERROR, cmake
understands "ERROR" as mere output string
- turn the macro into a function, otherwise 2 calls in the same
subdirectory are dangerous.
CCBUG: 371562
Test Plan: tests still pass, projects that use the macro still build
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Subscribers: dfaure
Differential Revision: https://phabricator.kde.org/D3178
|
|
REVIEW: 129188
|
|
|
|
|
|
|
|
The test checks that saving a read-only config file fails. But because root can write into read-only files, the test is failing when running by root. Check for uid when running the test and make it XFAIL if we are running as root.
REVIEW: 128916
|
|
|
|
|
|
|
|
REVIEW: 128608
CHANGELOG: Add Donate entry to KStandardShortcut
|
|
|
|
|
|
REVIEW: 128517
|
|
|
|
Don't drop the file: prefix twice in every run.
Use appropriate API on paths rather than string handling, when possible.
REVIEW: 127813
|
|
|
|
CCMAIL: elvis.angelaccio@kdemail.net
|
|
REVIEW: 128023
|
|
|
|
REVIEW:128102
Set encoding on kconfig_compiler generated cpp and headers
to utf-8 ( reproducible builds ) Under certain locals non
standard characters will get dropped making builds un reproducible.
Setting the encoding to utf-8 on the files makes all builds reproducible
no matter what ( or none ) locale is in use. Thereby making the build reproducible.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
entry we would skip the KAuthorized check. This is clearly wrong.
REVIEW: 127948
|
|
|
|
No one could be using this because they would not be able to link,
|
|
The typedef is copied here to avoid including the header that contains
it. However, this confuses sip if binding definitions are generated
from the C++ headers. Simply inline the typedef instead.
|
|
|
|
|
|
|
|
Just keep the setting once and always use QString::compare instead of
using QString::operator== or QString::compare depending on the platform.
|