| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
The extra load of values in KCoreConfigSkeleton is not documented anywhere
that it happens, and in normal circumstances re-loading new values isn't
expecterd during a save operation.
Update various mentions of readConfig/writeConfig to read/save.
Update documentation to match the new names of functions.
Rename writeConfig() to save() and usrWriteConfig() to usrSave()
Rename functions to match the new naming conventions. Also create old deprecated
instances of both functions to ensure that old code continues to operate
correctly. Also make save() non-virtual, for the same reasons read() is
now non-virtual.
Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig.
Rename usrReadConfig to usrRead, and mark the former as deprecated. To maintain
compatibility, usrRead still calls usrReadConfig in its default implementation.
usrReadConfig remains empty.
REVIEW: 117010
|
|
It is not on $PATH, so we cannot just expect QProcess to find it.
REVIEW: 117023
|
|
This is for the benefit of kded, which needs to run this binary.
REVIEW: 117023
|
|
LXR suggests nothing still sets that (everything is X-DocPath now).
REVIEW: 117003
|
|
Just because the executable has the "_kf5" suffix, that does not mean
the target should have it. This is ugly API, and will be unnecessary
porting effort for KF6.
REVIEW: 116995
|
|
The fact that it changed in KDE 4.3 is not so relevant any more.
REVIEW: 116962
|
|
These lines of code do not really require any justification.
REVIEW: 116962
|
|
REVIEW: 116962
|
|
All this ifdef'd-out code just makes it hard to see what's going on.
REVIEW: 116962
|
|
Not sure why it would be unset and then used, instead of just not used
at all. LXR says it's not used anywhere else, though.
REVIEW: 116962
|
|
As discussed with Matthew Dawson in review 116461.
|
|
|
|
Apps can reimplement usrReadConfig() or the readConfig() in every item instead.
|
|
|
|
Call it from generated singletons, since the constructor creates
a KConfig from a filename, which already loads from disk.
This removes the need for using DelayedParsing.
REVIEW: 116845
|
|
|
|
|
|
|
|
This test keeps deleting the whole ~/.qttest directory. By moving all
data into a subdirectory it is now possible to run multiple tests that
use kconfig in parallel.
REVIEW: 115875
|
|
|
|
|
|
|
|
kdeplatformtheme would load kdeglobals and the app config file, in order
to load settings, before the unittests get a chance to call
QStandardPaths::setTestModeEnabled(true). As a result, the test would
keep getting references to "wrong" shared config objects, pointing to
the real user's locations rather than the test directories.
This fixes e.g. kconfigdialog_unittest from kconfigwidgets for me
(it only passes on build.kde.org because it doesn't install frameworkintegration
for testing this framework)
REVIEW: 115963
|
|
returned by config().
This is useful when using kconfigxt and some other code to read from the same
config file (e.g. KColorScheme::contrastF(config)) - no need to call KSharedConfig::openConfig
twice, just grab the KSharedConfig from the generated class.
REVIEW: 115960
|
|
|
|
Previously the classes generated by kconfig_compiler would only emit
the defined signals when using the setters provided by that class.
However, when using e.g. KConfigDialog which uses
KConfigSkeletonItem::setProperty() to change the items no signal was
generated.
This patch fixes this by using a wrapper KConfigSkeletonItem
subclass that calls a private itemChanged() method in the generated
class which updates the set of changed properties. As soon as the item
is saved (usrWriteConfig() in the generated class is called) the signal
will be emitted
REVIEW: 115635
REVIEW: 115634
|
|
Previously the output of diff -u was written to a file when the
generated file did not match the expectations. Having the output printed
to stdout makes it easier to see the exact error without having to know
that a diff exists in a certain file somewhere in the build directory.
REVIEW: 115832
|
|
Ported with:
sed -i -e 's/\(include(\)CMake\(PackageConfigHelpers)\)/\1ECM\2/' \
-e 's/\<\(configure_package_config_file\)/ecm_\1/' \
CMakeLists.txt
See http://commits.kde.org/extra-cmake-modules/139f60d81653888f696ef433
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
QtTest and QtConcurrent are only required for autotests, so no need
to find them unconditionally.
QtWidgets is not actually used - QtGui is instead.
REVIEW: 114962
|
|
It is only needed for building the autotests
|
|
|
|
REVIEW: 114937
|
|
|
|
|
|
|
|
|
|
|
|
We should not depend on the fact that KDECompilerSettings.cmake happens
to include it when we use generate_export_header().
|
