diff options
| author | Daniel Vrátil <dvratil@kde.org> | 2019-08-22 13:00:49 +0200 |
|---|---|---|
| committer | Daniel Vrátil <dvratil@kde.org> | 2019-08-22 13:01:04 +0200 |
| commit | b9cf875e2e7de38b4fb3751346330ce909f6c44c (patch) | |
| tree | 94b1b3f5e4ec0825577324e37897409354d45f26 | |
| parent | 403c617eea56cc7581ee348e53d41eb4d291ba29 (diff) | |
| download | kconfig-b9cf875e2e7de38b4fb3751346330ce909f6c44c.tar.gz kconfig-b9cf875e2e7de38b4fb3751346330ce909f6c44c.tar.bz2 | |
Fix memory leak in KConfigWatcher
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: davidedmundson, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23340
| -rw-r--r-- | src/core/kconfigwatcher.cpp | 2 | ||||
| -rw-r--r-- | src/core/kconfigwatcher.h | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/src/core/kconfigwatcher.cpp b/src/core/kconfigwatcher.cpp index 2e7defcb..c9c500aa 100644 --- a/src/core/kconfigwatcher.cpp +++ b/src/core/kconfigwatcher.cpp @@ -90,6 +90,8 @@ KConfigWatcher::KConfigWatcher(const KSharedConfig::Ptr &config): #endif } +KConfigWatcher::~KConfigWatcher() = default; + void KConfigWatcher::onConfigChangeNotification(const QHash<QString, QByteArrayList> &changes) { //should we ever need it we can determine the file changed with QDbusContext::message().path(), but it doesn't seem too useful diff --git a/src/core/kconfigwatcher.h b/src/core/kconfigwatcher.h index 3a446d8e..00c0fab5 100644 --- a/src/core/kconfigwatcher.h +++ b/src/core/kconfigwatcher.h @@ -49,6 +49,8 @@ public: */ static Ptr create(const KSharedConfig::Ptr &config); + ~KConfigWatcher() override; + Q_SIGNALS: /** * Emitted when a config group has changed @@ -65,7 +67,7 @@ private Q_SLOTS: private: KConfigWatcher(const KSharedConfig::Ptr &config); Q_DISABLE_COPY(KConfigWatcher) - KConfigWatcherPrivate *const d; + const QScopedPointer<KConfigWatcherPrivate> d; }; #endif |