diff options
| author | Aleix Pol <aleixpol@kde.org> | 2016-11-09 00:54:56 +0100 |
|---|---|---|
| committer | Aleix Pol <aleixpol@kde.org> | 2016-11-17 12:16:36 +0100 |
| commit | 49203c61c7b6fc9629e85b118bdfcd1c468287ca (patch) | |
| tree | 24de16a9b7c1d3eb950a6d383186070c21fc58bd | |
| parent | 02977e550474912a0510ab035b30c2b7be6a0155 (diff) | |
| download | kconfig-49203c61c7b6fc9629e85b118bdfcd1c468287ca.tar.gz kconfig-49203c61c7b6fc9629e85b118bdfcd1c468287ca.tar.bz2 | |
Properly test environment variable
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty()
Reviewers: #frameworks, sebas, sitter
Reviewed By: sebas, sitter
Differential Revision: https://phabricator.kde.org/D3314
| -rw-r--r-- | src/core/ksharedconfig.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core/ksharedconfig.cpp b/src/core/ksharedconfig.cpp index f2de85be..c2997e9d 100644 --- a/src/core/ksharedconfig.cpp +++ b/src/core/ksharedconfig.cpp @@ -109,8 +109,8 @@ KSharedConfigPtr KSharedConfig::openConfig(const QString &_fileName, static bool userWarned = false; if (isMainThread && !userWarned) { userWarned = true; - QByteArray readOnly = qgetenv("KDE_HOME_READONLY"); - if (readOnly.isEmpty() && QCoreApplication::applicationName() != QLatin1String("kdialog")) { + const bool isReadOnly = qEnvironmentVariableIsEmpty("KDE_HOME_READONLY"); + if (isReadOnly && QCoreApplication::applicationName() != QLatin1String("kdialog")) { if (ptr->group("General").readEntry(QStringLiteral("warn_unwritable_config"), true)) { ptr->isConfigWritable(true); } |