kconfig.git/src, branch v5.55.0-rc1

[API dox] Include kconfig_compiler/README.dox for QCH generation

2019-02-02T03:11:29+00:00

GIT_SILENT

kconfig_compiler: delete the assignment operator and copy constructor

2019-01-10T20:03:36+00:00

Summary:
of the generated class that has a pointer and raw copy would be bad.

Those generated classes are internal and nobody would probably have this, but being safe never hurts

Reviewers: vkrause

Reviewed By: vkrause

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18136

KEmailSettings: Delete copy constructor and assignment operator

2019-01-10T19:44:20+00:00

Summary:
If someone was using them, it'd crash since it was raw-copying the d pointer
so you would end up with a double delete.

This is SIC, but IMHO it's fine, whoever gets a compiler failure has a bug to fix

Reviewers: vkrause

Reviewed By: vkrause

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18135

KonfUpdate: delete copy constructor and assignment operator

2019-01-09T20:44:42+00:00

they are unused, but if anyone would use them things would go wrong, so
protect us from it

Fix doxygen markup in KConfigWatcher

2019-01-03T14:32:10+00:00

Fix a regression introduced in 6a1852

2018-12-30T12:17:49+00:00

Summary:
Bytes from 'Strings' of type GroupString and KeyString should not be
escaped because they are valid UTF-8. Only instances of ValueString
should be escaped.

This fixes the failing test KConfigTest::testEncoding

Test Plan: Ran `ninja test` and found no errors.

Reviewers: dfaure, arichardson, apol, aacid, ngraham

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17856

Escape bytes that are larger than or equal to 127 in config files

2018-12-18T19:56:55+00:00

Summary:
UserBase tells me that KDE configuration files are encoded in UTF-8.
https://userbase.kde.org/KDE_System_Administration/Configuration_Files

In practice some *rc files have bytes outside that encoding. In my home directory I found two files that are not valid UTF-8.

I searched with
    find ~/.config/ -name '*rc' -exec file {} +
which gives these exceptions:

akonadiconsolerc: Non-ISO extended-ASCII text, with very long lines
kmail2rc: Non-ISO extended-ASCII text, with very long lines

In kmail2rc, the offending fields are
[AttachmentView]/State
[CollectionFolderView]/HeaderState

Both are QByteArray values saved from QHeaderView::saveState().

In the instance I found, the offending bytes were 0x81 and 0x84.

akonadiconsolerc had way more of these values. All seem related to saving widget state and hence probably QByteArrays.

The written QByteArray values look very strange. The bytes in the non-printable ASCII range are written as \xXX but the values above 127 are written literally.

The encoding is done  by KConfigIniBackend::stringToPrintable. It does not currently escape bytes that are larger than  or equal to 127.

Reviewers: dfaure, arichardson, apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17651

Fix documentation, QValueList isn't a thing anymore

2018-12-12T13:58:11+00:00

Reviewers: #frameworks, aacid

Reviewed By: aacid

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17491

USe isEmpty()

2018-11-30T07:49:23+00:00

normalize signal/slot

2018-11-04T22:13:53+00:00