kconfig.git/src, branch v5.54.0

Fix doxygen markup in KConfigWatcher

2019-01-03T14:32:10+00:00

Fix a regression introduced in 6a1852

2018-12-30T12:17:49+00:00

Summary:
Bytes from 'Strings' of type GroupString and KeyString should not be
escaped because they are valid UTF-8. Only instances of ValueString
should be escaped.

This fixes the failing test KConfigTest::testEncoding

Test Plan: Ran `ninja test` and found no errors.

Reviewers: dfaure, arichardson, apol, aacid, ngraham

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17856

Escape bytes that are larger than or equal to 127 in config files

2018-12-18T19:56:55+00:00

Summary:
UserBase tells me that KDE configuration files are encoded in UTF-8.
https://userbase.kde.org/KDE_System_Administration/Configuration_Files

In practice some *rc files have bytes outside that encoding. In my home directory I found two files that are not valid UTF-8.

I searched with
    find ~/.config/ -name '*rc' -exec file {} +
which gives these exceptions:

akonadiconsolerc: Non-ISO extended-ASCII text, with very long lines
kmail2rc: Non-ISO extended-ASCII text, with very long lines

In kmail2rc, the offending fields are
[AttachmentView]/State
[CollectionFolderView]/HeaderState

Both are QByteArray values saved from QHeaderView::saveState().

In the instance I found, the offending bytes were 0x81 and 0x84.

akonadiconsolerc had way more of these values. All seem related to saving widget state and hence probably QByteArrays.

The written QByteArray values look very strange. The bytes in the non-printable ASCII range are written as \xXX but the values above 127 are written literally.

The encoding is done  by KConfigIniBackend::stringToPrintable. It does not currently escape bytes that are larger than  or equal to 127.

Reviewers: dfaure, arichardson, apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17651

Fix documentation, QValueList isn't a thing anymore

2018-12-12T13:58:11+00:00

Reviewers: #frameworks, aacid

Reviewed By: aacid

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17491

USe isEmpty()

2018-11-30T07:49:23+00:00

normalize signal/slot

2018-11-04T22:13:53+00:00

Remove unused variable

2018-11-02T21:37:55+00:00

Reviewers: svuorela

Reviewed By: svuorela

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16565

Fix logic error in NotifyFlag testing

2018-10-15T15:04:58+00:00

Notify was changed to 0x08 | Persistent as it implied the other flag
state. However this change was not updated in the test.

Reviewed-by: Kai Uwe Broulik

Fix compilation without D-Bus

2018-10-10T16:26:49+00:00

Relevant on Android.

Add mechanism to notify other clients of config changes over DBus

2018-10-10T13:51:04+00:00

Summary:
Intention is not to create a registry like system, but to replace
KDElibs4Support::KGlobalSettings and to replace other system settingss
-> some app communication in a more generic way.

writeEntry gains an additional flag Notify which if set, will notify
clients of what has actually changed when we sync.

Rationale to put this into KConfig was so that we could have everything
batched and sychronised to the file sync and to get the fine detailed
exposure of what has actually changed which we don't get with a file
watcher.

Default behaviour remains identical without any broadcast messages.

As it is a new dependency it is purely optional and anything referencing
DBus is not in the public API. Our deployment on platforms without DBus
tend to be standalone applications anyway.

Test Plan: Attached unit test

Reviewers: broulik, dfaure

Reviewed By: broulik, dfaure

Subscribers: dfaure, broulik, zzag, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13034