kconfig.git/src, branch v5.43.0-rc1

Use Ctrl+Shift+, as the standard shortcut for "Configure "

2018-01-13T22:24:28+00:00

Summary: FEATURE: Use Ctrl+Shift+, as the standard keyboard shortcut to invoke KDE programs' "Configure " menu items.

Test Plan:
This shortcut is not used by anything else. Searched on lxr, found one conflict in DigiKam, and the developers agreed to change it: https://bugs.kde.org/show_bug.cgi?id=386335

Will wait to land this until Digikam 5.8.0 is released to prevent any shortcut conflicts.

Tested in KDE Neon. Tried out Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, and Skanlite; all now have a consistent keyboard shortcut for their "Configure " menu items.

Reviewers: #frameworks, #vdg, broulik, rkflx

Reviewed By: rkflx

Subscribers: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D8296

API docs: Sergio suggested create(), more readable than winId()

2017-12-08T14:04:26+00:00

API docs: full working code, including workaround for Qt issue...

2017-12-08T12:18:28+00:00

API docs: explain how to use KWindowConfig from a dialog constructor.

2017-12-08T12:05:16+00:00

Qt doesn't make it easy for us to just use QWindow...

Deprecate KDesktopFile::sortOrder()

2017-12-06T10:55:18+00:00

Summary:
The SortOrder key is deprecated by the Desktop Entry Specification:
https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html

Reviewers: dfaure, #frameworks

Reviewed By: dfaure

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D9224

Fix the result of KDesktopFile::sortOrder()

2017-12-06T10:01:02+00:00

Summary:
KDesktopFile::sortOrder() returns the value of SortOrder key
as a string whithout parsing it as a list.
But according to Desktop Entry Specification
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
it's type is "string(s)", i.e. the same type as the type of
Actions and MimeType keys, and thus it should be read the same way.

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: dfaure, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D8689

GIT_SILENT repair indentation

2017-12-02T08:57:54+00:00

Use Q_FALLTHROUGH

2017-11-30T11:03:49+00:00

Don't look for /etc/kderc every single time

2017-11-20T12:09:57+00:00

Summary:
Every time we open a configuration file, we are checking if this file is there.
Since it's a sysadmin setting I'd say it's fine to assume that it's not appearing
and disappearing.
Also we are not supporting the case of the file changing during runtime or so.

Reviewers: #frameworks, mpyne, dfaure

Reviewed By: mpyne, dfaure

Subscribers: dfaure, mpyne

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D8871

[KConfigGroup] reserve() more and add some C++11

2017-09-21T08:42:28+00:00

Using initializer_lists for QList we reserve the right amount of memory in advance and also make for nicer code.
Also uses range-for where code was touched and a const container used.

Differential Revision: https://phabricator.kde.org/D7879