kconfig.git/autotests/kconfig_compiler, branch v5.35.0

tests: use QIODevice::Text in kconfigcompiler_test

2017-05-25T22:57:35+00:00

This way, different newline endings in OSes are handled as \n when
reading, and thus fixing the comparison on non-\n OSes.

tests: use right QProcess API in kconfigcompiler_test

2017-05-25T22:40:20+00:00

Use the QProcess::start() variant with explicit (empty, in this case)
arguments, so the program string is not parsed as shell command, thus
preserving paths with spaces as such.

Prefer nullptr over Q_NULLPTR

2017-01-16T17:17:34+00:00

This should now use nullptr

2017-01-08T16:23:38+00:00

Generate an instance with KSharedConfig::Ptr for singleton and arg

2017-01-06T08:52:45+00:00

Summary:
In case a kcfg with arg="true" was used and singleton the static
instance method only accepted a QString config name. This made it
impossible to combine a singleton config with an already existing and
open KSharedConfig::Ptr.

With this change an overloaded instance method is added which takes a
KSharedConfig::Ptr as argument. The private ctor, though, only takes a
KSharedConfig::Ptr and the instance method taking a QString argument
uses KSharedConfig::openConfig on the config file name.

The change is source-incompatible in the following situation:
* kcfgfile arg="true"
* Singleton = true
* Inherits is specified

In this situation the previous revision created an instance method with
a QString argument and passed that to the parent constructor. This is
not in accordance with the documentation. Any user of this behavior was
relying on a bug. With this change now the call to the parent
constructor carries a KSharedConfigPtr.

Test Plan:
kconfigcompiler tests still pass and a config with singleton
and arg="true" generates the code as I need it

Reviewers: #frameworks, dfaure, mdawson

Differential Revision: https://phabricator.kde.org/D3690

kconfig_compiler: Use nullptr in generated code

2016-12-16T11:45:40+00:00

Reviewers: #frameworks, davidedmundson

Reviewed By: davidedmundson

Differential Revision: https://phabricator.kde.org/D3702

Revert "Generate an instance with KSharedConfig::Ptr for singleton and arg"

2016-12-07T08:29:38+00:00

This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839.

As suggested by Martin on release-team@kde.org, given that it breaks SC.

Revert "[autotest] Fix stupidity"

2016-12-07T08:29:27+00:00

This reverts commit 71f16741a0288d8587876dcc7dbb33ba8f00546a.

[autotest] Fix stupidity

2016-12-02T18:45:17+00:00

Sorry.

Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-12-02T18:04:13+00:00

Summary:
In case a kcfg with arg="true" was used and singleton the static
instance method only accepted a QString config name. This made it
impossible to combine a singleton config with an already existing and
open KSharedConfig::Ptr.

With this change an overloaded instance method is added which takes a
KSharedConfig::Ptr as argument. The private ctor, though, only takes a
KSharedConfig::Ptr and the instance method taking a QString argument
uses KSharedConfig::openConfig on the config file name.

This provides full API compatibility and at the same time allows to use
KSharedConfig in addition to the arg name based variant.

Test Plan:
kconfigcompiler tests still pass and a config with singleton
and arg="true" generates the code as I need it

Reviewers: #frameworks

Differential Revision: https://phabricator.kde.org/D3386