kconfig.git/autotests/kconfig_compiler, branch v5.29.0 hurd kconfig.git Revert "Generate an instance with KSharedConfig::Ptr for singleton and arg" 2016-12-07T08:29:38+00:00 David Faure faure@kde.org 2016-12-07T08:29:31+00:00 4f9d7dde3a06da26d93e8f7ec98a283111a2d8c9 This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839. As suggested by Martin on release-team@kde.org, given that it breaks SC. 
This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839.

As suggested by Martin on release-team@kde.org, given that it breaks SC.
Revert "[autotest] Fix stupidity" 2016-12-07T08:29:27+00:00 David Faure faure@kde.org 2016-12-07T08:29:27+00:00 ebcaf997ca4e7cf687604ccb081d577f87b08008 This reverts commit 71f16741a0288d8587876dcc7dbb33ba8f00546a. 
This reverts commit 71f16741a0288d8587876dcc7dbb33ba8f00546a.
[autotest] Fix stupidity 2016-12-02T18:45:17+00:00 Martin Gräßlin mgraesslin@kde.org 2016-12-02T18:45:17+00:00 71f16741a0288d8587876dcc7dbb33ba8f00546a Sorry. 
Sorry.
Generate an instance with KSharedConfig::Ptr for singleton and arg 2016-12-02T18:04:13+00:00 Martin Gräßlin mgraesslin@kde.org 2016-11-16T13:59:28+00:00 cd4e6504dfbdface00037625f0cedda511e6d839 Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. This provides full API compatibility and at the same time allows to use KSharedConfig in addition to the arg name based variant. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks Differential Revision: https://phabricator.kde.org/D3386 
Summary:
In case a kcfg with arg="true" was used and singleton the static
instance method only accepted a QString config name. This made it
impossible to combine a singleton config with an already existing and
open KSharedConfig::Ptr.

With this change an overloaded instance method is added which takes a
KSharedConfig::Ptr as argument. The private ctor, though, only takes a
KSharedConfig::Ptr and the instance method taking a QString argument
uses KSharedConfig::openConfig on the config file name.

This provides full API compatibility and at the same time allows to use
KSharedConfig in addition to the arg name based variant.

Test Plan:
kconfigcompiler tests still pass and a config with singleton
and arg="true" generates the code as I need it

Reviewers: #frameworks

Differential Revision: https://phabricator.kde.org/D3386
kconfig_compiler - generate code with overrides 2016-11-12T13:49:51+00:00 Allen Winter winter@kde.org 2016-11-12T13:49:51+00:00 b66da09e586dda28ca43c6566904a0f62a787863 REVIEW: 129382 
REVIEW: 129382
Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES 2016-10-30T23:27:42+00:00 Aleix Pol aleixpol@kde.org 2016-10-28T10:46:17+00:00 91dbd2f5a30caf878f668e60b7c2ee5ca376b858 Summary: Instead of having an odd fake of it. Will help some required refactorings and already showed some issues, fixed by this patch, namely: - don't use string(regex replace) to extract a string from another string. in case it doesn't match it will offer the whole content which is never what we want. - messages(ERROR), the correct parameter is FATAL_ERROR, cmake understands "ERROR" as mere output string - turn the macro into a function, otherwise 2 calls in the same subdirectory are dangerous. CCBUG: 371562 Test Plan: tests still pass, projects that use the macro still build Reviewers: #frameworks, dfaure Reviewed By: dfaure Subscribers: dfaure Differential Revision: https://phabricator.kde.org/D3178 
Summary:
Instead of having an odd fake of it. Will help some required
refactorings and already showed some issues, fixed by this patch,
namely:
- don't use string(regex replace) to extract a string from another
string. in case it doesn't match it will offer the whole content which
is never what we want.
- messages(ERROR), the correct parameter is FATAL_ERROR, cmake
understands "ERROR" as mere output string
- turn the macro into a function, otherwise 2 calls in the same
subdirectory are dangerous.

CCBUG: 371562

Test Plan: tests still pass, projects that use the macro still build

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: dfaure

Differential Revision: https://phabricator.kde.org/D3178
kconfigcompiler_test_signals.cpp - pedantic 2016-04-16T17:19:07+00:00 Allen Winter winter@kde.org 2016-04-16T17:19:07+00:00 9da196bbc3429c9985ca7cedd1533a75d14c1580 






Fix some Clazy warnings
2015-12-23T14:57:57+00:00

Imran Tatriev
itatriev@gmail.com

2015-12-23T14:57:57+00:00

74d30c02373383748219318372907539d8259250












Use QStringLiteral in generated code
2015-10-30T22:31:09+00:00

Montel Laurent
montel@kde.org

2015-10-28T07:29:32+00:00

75d11cc64fee09189bfe8f968f0558e3d1000db8

REVIEW: 125833





REVIEW: 125833







Fix unit-tests, expected output changed, so update the tests.
2015-08-18T22:18:16+00:00

Sergio Martins
iamsergio@gmail.com

2015-08-18T22:18:16+00:00

0c04b8cc4021934bbd6e0bd12788396689f65864