kconfig.git/autotests/kconfig_compiler/test8c.h.ref, branch v5.40.0-rc1 hurd kconfig.git Generate an instance with KSharedConfig::Ptr for singleton and arg 2017-01-06T08:52:45+00:00 Martin Gräßlin mgraesslin@kde.org 2016-11-16T13:59:28+00:00 e0db2422362260a2fea3a8e1de4c64011d2f183d Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. The change is source-incompatible in the following situation: * kcfgfile arg="true" * Singleton = true * Inherits is specified In this situation the previous revision created an instance method with a QString argument and passed that to the parent constructor. This is not in accordance with the documentation. Any user of this behavior was relying on a bug. With this change now the call to the parent constructor carries a KSharedConfigPtr. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks, dfaure, mdawson Differential Revision: https://phabricator.kde.org/D3690 
Summary:
In case a kcfg with arg="true" was used and singleton the static
instance method only accepted a QString config name. This made it
impossible to combine a singleton config with an already existing and
open KSharedConfig::Ptr.

With this change an overloaded instance method is added which takes a
KSharedConfig::Ptr as argument. The private ctor, though, only takes a
KSharedConfig::Ptr and the instance method taking a QString argument
uses KSharedConfig::openConfig on the config file name.

The change is source-incompatible in the following situation:
* kcfgfile arg="true"
* Singleton = true
* Inherits is specified

In this situation the previous revision created an instance method with
a QString argument and passed that to the parent constructor. This is
not in accordance with the documentation. Any user of this behavior was
relying on a bug. With this change now the call to the parent
constructor carries a KSharedConfigPtr.

Test Plan:
kconfigcompiler tests still pass and a config with singleton
and arg="true" generates the code as I need it

Reviewers: #frameworks, dfaure, mdawson

Differential Revision: https://phabricator.kde.org/D3690
Revert "Generate an instance with KSharedConfig::Ptr for singleton and arg" 2016-12-07T08:29:38+00:00 David Faure faure@kde.org 2016-12-07T08:29:31+00:00 4f9d7dde3a06da26d93e8f7ec98a283111a2d8c9 This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839. As suggested by Martin on release-team@kde.org, given that it breaks SC. 
This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839.

As suggested by Martin on release-team@kde.org, given that it breaks SC.
Revert "[autotest] Fix stupidity" 2016-12-07T08:29:27+00:00 David Faure faure@kde.org 2016-12-07T08:29:27+00:00 ebcaf997ca4e7cf687604ccb081d577f87b08008 This reverts commit 71f16741a0288d8587876dcc7dbb33ba8f00546a. 
This reverts commit 71f16741a0288d8587876dcc7dbb33ba8f00546a.
[autotest] Fix stupidity 2016-12-02T18:45:17+00:00 Martin Gräßlin mgraesslin@kde.org 2016-12-02T18:45:17+00:00 71f16741a0288d8587876dcc7dbb33ba8f00546a Sorry. 
Sorry.
Generate an instance with KSharedConfig::Ptr for singleton and arg 2016-12-02T18:04:13+00:00 Martin Gräßlin mgraesslin@kde.org 2016-11-16T13:59:28+00:00 cd4e6504dfbdface00037625f0cedda511e6d839 Summary: In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. This provides full API compatibility and at the same time allows to use KSharedConfig in addition to the arg name based variant. Test Plan: kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it Reviewers: #frameworks Differential Revision: https://phabricator.kde.org/D3386 
Summary:
In case a kcfg with arg="true" was used and singleton the static
instance method only accepted a QString config name. This made it
impossible to combine a singleton config with an already existing and
open KSharedConfig::Ptr.

With this change an overloaded instance method is added which takes a
KSharedConfig::Ptr as argument. The private ctor, though, only takes a
KSharedConfig::Ptr and the instance method taking a QString argument
uses KSharedConfig::openConfig on the config file name.

This provides full API compatibility and at the same time allows to use
KSharedConfig in addition to the arg name based variant.

Test Plan:
kconfigcompiler tests still pass and a config with singleton
and arg="true" generates the code as I need it

Reviewers: #frameworks

Differential Revision: https://phabricator.kde.org/D3386