From f3f4893b5bd20a32dd48b147fdd243c3226a06f3 Mon Sep 17 00:00:00 2001 From: Harald Sitter Date: Mon, 23 Sep 2019 16:00:59 +0200 Subject: new module ECMSourceVersionControl Summary: simply sets a variable when the source is under version control. use it to auto-enable Debug builds. there are also plans to switch special assertion logic on in KIO when used from git, so there definitely is a more generic use case of wanting to control behavior based on whether it the source is likely used to make a development or production build. conceivably the module could be used in the future to get git rev-parse or the like, hence the generic name. Test Plan: with .git the var is true, without it is false Reviewers: kde-buildsystem, dfaure Reviewed By: dfaure Subscribers: apol, kossebau, kde-frameworks-devel Tags: #frameworks, #build_system Differential Revision: https://phabricator.kde.org/D24159 --- kde-modules/KDECompilerSettings.cmake | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'kde-modules/KDECompilerSettings.cmake') diff --git a/kde-modules/KDECompilerSettings.cmake b/kde-modules/KDECompilerSettings.cmake index 41a4a2e5..7eb5cd41 100644 --- a/kde-modules/KDECompilerSettings.cmake +++ b/kde-modules/KDECompilerSettings.cmake @@ -66,21 +66,21 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +include("${ECM_MODULE_DIR}/ECMSourceVersionControl.cmake") + ############################################################ # Default build type # If no build type was specified, default to using a debug build if the # source directory is a git clone. # Otherwise, leave it empty, to let distro packagers choose the flags. ############################################################ -if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) - if (EXISTS "${CMAKE_SOURCE_DIR}/.git") - set(default_build_type "Debug") - message(STATUS "Setting build type to '${default_build_type}' as none was specified.") - set_property(CACHE CMAKE_BUILD_TYPE PROPERTY VALUE "${default_build_type}") - # Set the possible values of build type for cmake-gui - set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS - "Debug" "Release" "MinSizeRel" "RelWithDebInfo") - endif() +if (ECM_SOURCE_UNDER_VERSION_CONTROL AND NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) + set(default_build_type "Debug") + message(STATUS "Setting build type to '${default_build_type}' as none was specified.") + set_property(CACHE CMAKE_BUILD_TYPE PROPERTY VALUE "${default_build_type}") + # Set the possible values of build type for cmake-gui + set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS + "Debug" "Release" "MinSizeRel" "RelWithDebInfo") endif() ############################################################ -- cgit v1.2.1