From 7b05256f9e8a5d87a4aa2a3a9b84ec9ce8a65fe5 Mon Sep 17 00:00:00 2001 From: Gabriel Souza Franco Date: Sat, 12 Sep 2020 21:12:00 -0300 Subject: Explicitly sort Android version lists Also document --android-platform parameter --- toolchain/Android.cmake | 2 ++ toolchain/ECMAndroidDeployQt.cmake | 3 +++ 2 files changed, 5 insertions(+) diff --git a/toolchain/Android.cmake b/toolchain/Android.cmake index e3ace15a..de40c986 100644 --- a/toolchain/Android.cmake +++ b/toolchain/Android.cmake @@ -142,6 +142,7 @@ set_deprecated_variable(CMAKE_ANDROID_ARCH_ABI ANDROID_ABI "$ENV{ANDROID_ARCH_AB set(ANDROID_SDK_ROOT "$ENV{ANDROID_SDK_ROOT}" CACHE PATH "Android SDK path") file(GLOB platforms LIST_DIRECTORIES TRUE RELATIVE ${ANDROID_SDK_ROOT}/platforms ${ANDROID_SDK_ROOT}/platforms/*) +list(SORT platforms COMPARE NATURAL) list(GET platforms -1 _default_platform) set(ANDROID_SDK_COMPILE_API "${_default_platform}" CACHE STRING "Android API Level") if(ANDROID_SDK_COMPILE_API MATCHES "^android-([0-9]+)$") @@ -149,6 +150,7 @@ if(ANDROID_SDK_COMPILE_API MATCHES "^android-([0-9]+)$") endif() file(GLOB build-tools LIST_DIRECTORIES TRUE RELATIVE ${ANDROID_SDK_ROOT}/build-tools ${ANDROID_SDK_ROOT}/build-tools/*) +list(SORT build-tools COMPARE NATURAL) list(GET build-tools -1 _default_sdk) set(ANDROID_SDK_BUILD_TOOLS_REVISION "${_default_sdk}" CACHE STRING "Android Build Tools version") diff --git a/toolchain/ECMAndroidDeployQt.cmake b/toolchain/ECMAndroidDeployQt.cmake index d6ef8778..b04b5dd7 100644 --- a/toolchain/ECMAndroidDeployQt.cmake +++ b/toolchain/ECMAndroidDeployQt.cmake @@ -80,6 +80,9 @@ function(ecm_androiddeployqt QTANDROID_EXPORTED_TARGET ECM_ADDITIONAL_FIND_ROOT_ COMMAND LANG=C cmake -DINPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json.in2" -DOUTPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json" "-DTARGET=$" "-DOUTPUT_DIR=$" "-DEXPORT_DIR=${CMAKE_INSTALL_PREFIX}" "-DECM_ADDITIONAL_FIND_ROOT_PATH=\"${ECM_ADDITIONAL_FIND_ROOT_PATH}\"" "-DANDROID_EXTRA_LIBS=\"${ANDROID_EXTRA_LIBS}\"" -P ${_CMAKE_ANDROID_DIR}/specifydependencies.cmake COMMAND $/androiddeployqt --gradle --input "${QTANDROID_EXPORTED_TARGET}-deployment.json" --apk "${ANDROID_APK_OUTPUT_DIR}/${QTANDROID_EXPORTED_TARGET}-${CMAKE_ANDROID_ARCH_ABI}.apk" --output "${EXPORT_DIR}" --android-platform android-${ANDROID_SDK_COMPILE_API} --deployment bundled ${arguments} ) + # --android-platform above is only available as a command line option + # This specifies the actual version of the SDK files to use, and + # can be different from both the NDK target and the Java API target. add_custom_target(install-apk-${QTANDROID_EXPORTED_TARGET} COMMAND adb install -r "${ANDROID_APK_OUTPUT_DIR}/${QTANDROID_EXPORTED_TARGET}-${CMAKE_ANDROID_ARCH_ABI}.apk" -- cgit v1.2.1