From 340b969f54d2f271e925ed7f84c831e1e4b2ccd0 Mon Sep 17 00:00:00 2001 From: "R.J.V. Bertin" Date: Tue, 30 May 2017 01:05:18 +0200 Subject: restore hidden-visibility testing with Xcode 6.2 Xcode 6.2 (OS X 10.9.5) has a Clang version that is based on Clang 3.5 but does not yet support -Wdate-time . Commit 7af9f8e2b6eb235923a329e8ff24012883fb6b86 introduced a regression where this compiler failed to pass the visibility tests because it prints a warning about -Wdate-time. This in turn leads to linker errors. --- kde-modules/KDECompilerSettings.cmake | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kde-modules/KDECompilerSettings.cmake b/kde-modules/KDECompilerSettings.cmake index 8f87ecc1..2de98c04 100644 --- a/kde-modules/KDECompilerSettings.cmake +++ b/kde-modules/KDECompilerSettings.cmake @@ -376,8 +376,10 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR endif() if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0) OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.5)) - # -Wdate-time: warn if we use __DATE__ or __TIME__ (we want to be able to reproduce the exact same binary) - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wdate-time") + if (NOT (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 6.1.0.6000000)) + # -Wdate-time: warn if we use __DATE__ or __TIME__ (we want to be able to reproduce the exact same binary) + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wdate-time") + endif() endif() # -w1 turns on warnings and errors -- cgit v1.2.1