From 0ce3a1e6440db8190a4c7da5535b632df76bf1cb Mon Sep 17 00:00:00 2001 From: David Faure Date: Sun, 12 Jul 2009 22:37:46 +0000 Subject: Always define MAKE_FOO_LIB, not only on Windows. This is used in konqueror to know when to enable KDE_TESTS_EXPORT. What I don't understand, is why it worked before; konqprivate_export.h always relied on MAKE_KDEINIT_KONQUEROR_LIB... (and without this commit, konqviewmgrtest failed with undefined symbol KonqSettings::self(), which is logical [hidden symbol]) svn path=/trunk/KDE/kdelibs/; revision=995537 --- modules/KDE4Macros.cmake | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/modules/KDE4Macros.cmake b/modules/KDE4Macros.cmake index ef5c61b1..1b7a934e 100644 --- a/modules/KDE4Macros.cmake +++ b/modules/KDE4Macros.cmake @@ -578,13 +578,11 @@ macro (KDE4_ADD_PLUGIN _target_NAME _with_PREFIX) set_target_properties(${_target_NAME} PROPERTIES PREFIX "lib") endif (_first_SRC) - if (WIN32) - # for shared libraries/plugins a -DMAKE_target_LIB is required - string(TOUPPER ${_target_NAME} _symbol) - string(REGEX REPLACE "[^_A-Za-z0-9]" "_" _symbol ${_symbol}) - set(_symbol "MAKE_${_symbol}_LIB") - set_target_properties(${_target_NAME} PROPERTIES DEFINE_SYMBOL ${_symbol}) - endif (WIN32) + # for shared libraries/plugins a -DMAKE_target_LIB is required + string(TOUPPER ${_target_NAME} _symbol) + string(REGEX REPLACE "[^_A-Za-z0-9]" "_" _symbol ${_symbol}) + set(_symbol "MAKE_${_symbol}_LIB") + set_target_properties(${_target_NAME} PROPERTIES DEFINE_SYMBOL ${_symbol}) endmacro (KDE4_ADD_PLUGIN _target_NAME _with_PREFIX) -- cgit v1.2.1