extra-cmake-modules.git - hurd extra-cmake-modules.git

Age	Commit message (Collapse)	Author
2022-06-12	API dox: use more markup for code or commandline samples	Friedrich W. H. Kossebau
	NO_CHANGELOG
2021-11-18	AddAppIcon: clarify ksvg2icns role for @2x icons	Dawid Wrobel
	The description was a bit misleading and may have suggested that ksvg2icons was required for @2x (Retina) icons to work.
2021-05-15	ECMAddAppIcon: support target as argument	Friedrich W. H. Kossebau

2021-04-23	Modules docs: move rst docs into bracket comments	Friedrich W. H. Kossebau
	CMake >= 3.0 supports bracket comments, and the reStructuredText integration code in sphinx/ext/ecm.py already supports extracting the docs from a bracket comment instead. Editing documentation without leading line comment markers is more simple, e,g. when reflowing text over lines. With ECM meanwhile requiring CMake 3.5 now it is possible to switch (and thus follow also the approach used by cmake itself). NO_CHANGELOG
2020-06-24	Remove support for png2ico	Hannah von Reth
	Png2Ico provides lower quality icons compared to icoutils as png2ico predates the current icon standard. Still lloking for png2ico prints * Png2Ico, Executable that converts a collection of PNG files into a Windows icon file, <https://www.winterdrache.de/freeware/png2ico/ or https://commits.kde.org/kdewin> which confuses new users.
2020-06-14	extra-cmake-modules: Convert to SPDX license statements	Andreas Cord-Landwehr

2020-01-26	ECMAddAppIcon: Add sc in regex to extract extension from valid names	Patrick José Pereira
	Summary: Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com> Reviewers: tcanabrava, apol Reviewed By: tcanabrava, apol Subscribers: kde-frameworks-devel, kde-buildsystem Tags: #frameworks, #build_system Differential Revision: https://phabricator.kde.org/D26751
2018-07-16	Change the 'since' version.	Christophe Giboudeaux
	These changes are not available in ECM 5.48.0.
2018-07-08	Improve ECMAddAppIconMacro.	Dominik Schmidt
	Summary: - Add support for SIDEBAR_ICONS on macOS - Allow specifying a basename for the icon file via OUTFILE_BASENAME - Add support for HiRes icons on Windows via icotool I'm sorry this went all into one big change. I see that it's not optimal, but it's really hard to rip it apart... Also to me the whole code with support for two flavors of png2ico and icotool seems very spaghetti-ish. IMHO there's no good reason to keep supporting all three, icotool is the only maintained project and the only one supporting more than 128px wide icons. That's why I would suggest to simplify the whole code by only supporting icotool in one of the next releases. Test Plan: We use this version of ECMAddAppIconMacro in ownCloud client and it works... I tested icotool natively and while cross-compiling on linux. SIDEBAR_ICONS are also working... If you want to test this with the ownCloud client, it's best to use https://github.com/dschmidt/owncloud-client/tree/fix-app-icon-macro because that contains a small fix I just PR'ed and which is not in master yet. (We maintain a fork of the module there, so compiling it for Windows or macOS will automatically use the version of the module that I'm submitting) Reviewers: vonreth, vpinon, apol, alexmerry, cgiboudeaux Reviewed By: cgiboudeaux Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem Tags: #frameworks, #build_system Differential Revision: https://phabricator.kde.org/D13698
2017-01-10	ecm_add_app_icon : ignore SVG files silently when unsupported	R.J.V. Bertin
	SVG files that fail to convert will still trigger a warning.
2017-01-10	Update the ecm_add_app_icon documentation	R.J.V. Bertin
	Inform the user that SVG icons can now be provided in the macro call; on Mac the first that converts to .icns (if ksvg2icns is available) will provide the application icon. Other SVG files are ignored, idem on other platforms.
2017-01-09	ecm_add_app_icon/Mac: accept SVG icons when KIconThemes is installed	R.J.V. Bertin
	KIconThemes comes with a ksvg2icns utility that converts .sgv and .sgvz files to native .icns icon files. Using this utility allows to create icons with optimum resolution regardless of the available .png images and of limitations of the host's iconutil application (limited to 256x256 on some Mac OS versions). REVIEW: 128162
2016-08-31	add full license text	Allen Winter
	REVIEW: 128780
2016-01-31	ECMAddAppIcon: Use absolute path when operating on icons.	Gleb Popov
	REVIEW: 126711
2015-12-18	CMake: Cleanup: Strip text from endif/else	Kevin Funk
	REVIEW: 126414
2015-02-06	Document when modules were added to ECM.	Alex Merry

2015-01-24	Add ecm_add_app_icon function.	Alex Merry
	This adds an application icon to an executable from PNG files for Windows and Mac OS X. Unlike the similar kde4_add_app_icon macro from kdelibs, this requires icons to be explicitly listed as arguments (meaning CMake can tell when ones are added or deleted and reconfigure as appropriate), and it works with Matthias Benkmann's png2ico tool, as well as the KDE-Win tool of the same name. Currently missing unit tests. Also completely untested (except that `make test` runs on Linux, so there are no obvious syntax errors). With thanks to Ralf Habacker for the inital work on porting kde4_add_app_icon. CHANGELOG: Add ECMAddAppIcon module to add icons to executable targets on Windows and Mac OS X.