Age | Commit message (Collapse) | Author |
|
|
|
It is only needed for users of kde_file, so more it to a more
relevant place.
|
|
|
|
On multi-config generators, that variable is not set, so cmake fails
on it.
|
|
|
|
CMake already knows the flag to use, and it is not always -fPIE.
See the output of git grep CMAKE_C_COMPILE_OPTIONS_PIE in cmake
for example. Therefore, there's no need to issue a message either.
|
|
http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/7727
|
|
The only use of this was removed recently in 93457e172cf17a442938614cca1862a2dcfd889f
|
|
Qt 5 does not support it.
|
|
These are already set by add_compiler_export_flags which is invoked
below.
|
|
It is not clear whether the allocator is still 'bad' in more-recent
GCC versions, but let's pretend we know it is.
|
|
Same as 21c3f0bed3b758baefb9b760efb0c2dd by Patrick von Reth in kdelibs.
He says:
"dont disable auto-import, to make it possible to build with a newer mingw
which doesnt have proper exports for c++ standart libs
The problem occurs with all gcc versions newer then 4.4.
In preparation for Qt5 I started to work with newer builds, currently 4.7.2.
The change should not have any negative effects on 4.4 and earlier
versions, but is essential to make it build with a newer version."
Alex
|
|
This can be removed once we require cmake 2.8.11, then it will work
automatically.
Alex
|
|
Instead of testing for it, we can simply use the information provided
by Qt5 config.cmake files
Alex
|
|
Alex
|
|
-reenable the test for visibility in Qt
-reenable the test for FILE_OFFSET_BITS=64 (... there may be maybe some embedded systems where this is not the case ?)
-add -Wl,--disable-auto-import for mingw, we have that in FindKDE4Internal.cmake too
Alex
|
|
<thiago> that's an C++11-violating option. Time to stop using it.
(and Qt5.1's Q_GLOBAL_STATIC relies on it)
|
|
|
|
Alex
|
|
There was no reason to add more flags only on Linux/Hurd; in fact, in
kdelibs' FindKDE4Internal.cmake there's also a block with similar
settings for the BSDs.
Make it more general by removing the system checks before setting
these flags. -Wno-long-long is particularly needed when one is
building code with -pedantic (see picmi, for example).
CCMAIL: kde-buildsystem@kde.org
|
|
In preparation for making having the default CXXFLAGS available on all
systems using GCC instead of only Linux/Hurd, remove -ansi from the
CXXFLAGS.
strtoll(3), used, for example, in kdelibs, is part of C99; -ansi means
GCC will switch to C89 and C++98, which breaks things on systems such
as FreeBSD. It worked on glibc-based systems because libstdc++ always
defines _GNU_SOURCE on Linux, which ends up enabling additional
features.
This change should not break existing code, as dropping -ansi actually
means being less strict than before.
Discussed in the kde-buildsystem mailing list [1].
[1] http://lists.kde.org/?t=134482883000001&r=1&w=2
CCMAIL: kde-buildsystem@kde.org
|
|
It is not completely clear why this flag was being specified in the
first place: it was added in the commit that created
FindKDE4.cmake (KDE SVN r497283), and seems to have been ported
automatically from the autotools code.
In autotools, its origins can be tracked back to KDE SVN r141814,
which was a libtool update. In that case, -lc was only passed on AIX
systems anyway.
|
|
This macro only makes sense on glibc-based systems, which honour that
definition according to feature_test_macros(7).
|
|
-rename the cmake package from extra-cmake-modules to ECM
-change variable names and docs accordingly
-move setting of Qt-related defines from ECMQtFrameworks.cmake to KDECompilerSettings.cmake
-remove ECMSetVersionVariables.cmake, we'll do it some other way
-rename ECMConfig.cmake.in to ECMQtFrameworkConfig.cmake.in, since this is where it is used, and it would have the same name as ECMConfig.cmake.in which is for extra-cmake-modules itself
Alex
|
|
Alex
|
|
Alex
|
|
ECMQtFramework.cmake now uses
- KDEInstallDirs.cmake, so it doesn't have to define th install locations itself anymore
- KDECompilerSettings.cmake, so it gets the full set we had in kdelibs4
- KDECMakeSettings, so it gets the full set of cmake features as before, and some more, RPATH, etc.
Alex
|
|
Alex
|
|
-make some endif()s empty
-set the linker flags on Linux in one step, not in two
Alex
|
|
settings from FindKDE4Internal.cmake
This is not done yet.
It currently depends on cmake git master.
All the places where I'm not sure I added a "TODO".
Alex
|