| Age | Commit message (Collapse) | Author |
|---|
|
We have identical copies of this in kinit, kwin, ksysguard and
powerdevil. This makes it a natural candidate for inclusion in ECM.
|
|
When the qt install prefix and the qt host data path are the same,
CMake's RELATIVE_PATH file path function will return the empty string.
This made us accidentally set ECM_MKSPECS_INSTALL_DIR to /mkspecs/modules.
Fix this by explicitly checking for the empty string. Once we can depend on
CMake 3.20, we can use CMake's builtin function for joining paths instead.
|
|
When building multiple KDE projects, installing them to "$DESTDIR"
and having cmake look for kde dependencies in "$DESTDIR" using
"CMAKE_PREFIX_PATH=$DESTDIR/usr", we currently get failures when
calling find_package() on projects that use KDE_INSTALL_QTPLUGINDIR,
KDE_INSTALL_QTQMLDIR and KDE_INSTALL_QTQUICKIMPORTSDIR because these
are defined as absolute paths when KDE_INSTALL_USE_QT_SYS_PATHS is
enabled.
This commit defines these paths relative to qmake's QT_INSTALL_PREFIX
property instead when KDE is install to the same prefix as Qt. This
fixes DESTDIR installations because with relative paths, CMake will
search for these paths in "$DESTDIR" as well as "/".
We limit this change to the scenario where the Qt and CMake install
prefixes are the same because always doing this would break backwards
compatibility as qml and plugins would be installed into CMAKE_INSTALL_PREFIX
instead of QT_INSTALL_PREFIX after this change.
|
|
The --sort=name option was only added in version 1.28
which isn't available in Centos 7 yet e.g.
|
|
|
|
This is no longer needed now that the metadata happens as part of the
build process rather than afterwards on the signing system. This allows
us to simplify the code here a bit.
|
|
|
|
GIT_SILENT
|
|
|
|
It was reported that in case of containerized setups where the
source and build are in different containers the pre-commit
script would reference a file which is another container and
is consequently not found.
To avoid this the script is copied in the source dir and a relative path is defined.
|
|
This makes it more difficult to implement the relative paths.
It would be nice to have, but if we encounter a scenario
where we explicitly need this we can revisit it.
|
|
|
|
|
|
|
|
This way we pass the regex on an actual URL that we may understand.
This is especially useful when url.insteadOf entries are specified in
~/.gitconfig.
|
|
|
|
Those occur for example in Marble.
|
|
|
|
This reverts commit a6be96a0c84b215de7f6fb397255af252adf7fc1.
|
|
To prevent cmake errors with exiting usages it is checked if the target already exists.
|
|
|
|
|
|
On Gentoo the permissions are differently set, which causes
problems when running cmake.
BUG: 431768
FIXED-IN: 5.79
|
|
Ensures that the files
* are re-created by build rule when accidentally deleted in the build dir
* are not getting new timestamps on every cmake run, even when content
has not changed
|
|
|
|
|
|
|
|
GIT_SILENT
|
|
This will allow us to force QS checks before
the developer commits a change. Currently only
clang-format is supported, but as on #plasma and
https://phabricator.kde.org/T11214 discussed we
might want to add different formatters.
By making the checks configurable we are flexible
and can easily extend it.
|
|
|
|
|
|
COLS_IN_ALPHA_INDEX got obsolete in doxygen 1.9.0, besides not being
used anyway due to ALPHABETICAL_INDEX being set to NO.
Also remove IGNORE_PREFIX, unused as well due to ALPHABETICAL_INDEX=NO
NO_CHANGELOG
|
|
For GCC/Clang that is the default, but not for MSVC. This can cause both
compile-time and runtime errors when encountering string literals that
contain more than just 7bit ASCII.
Some of our modules set this already, others use various other workarounds
to avoid Utf-8 literals, so better do this consistently and centrally.
Qt6 will also set this by default.
This is actually Hannah's finding from debugging issues caused by this
in kitinerary, I'm just submitting the patch.
|
|
|
|
Before this value was 240, which can result in excessively long lines.
|
|
It is based on the one that can be found in KWin.
Several KDE projects already use libepoxy (KWin and KDeclarative).
|
|
This adds support for image assets not represented in the appstream data,
such as the banner image for the F-Droid app, and it allows to override
appstream screenshots by local ones. The latter is e.g. used by KTrip
which provides Android-specific screenshots that way.
|
|
|
|
- Search for a suitable `tar` program
- Check version output if it's GNU tar
Since this function is typically run only once per repo,
there's not much point in doing extra cache work or writing
a separate find-module.
|
|
This should improve the alignment issues currently seen in bullet point
lists that we use frequently in the description text.
|
|
BUG: 424392
|
|
This makes use of the CMake 3.19 DEFER command to list all MODULE
targets after processing the toplevel CMakeLists. This allows us to
collect required dependencies of all plugins without changes to the
application. For example, this will fix Okular not including Poppler
because it is only linked from the plugin, thus not being able to
actually read PDFs.
|
|
NO_CHANGELOG
|
|
|
|
|
|
Locally unlink() seems to work just fine on non-existent files, but on
binary factory that seems to be different for some reason.
|
|
This matters when reusing output folders (as binary factory does for
example), as we then retain outdated screenshots and just keep adding
files to an already existing fastlane archive.
|
|
Also, check for the HTTP status code, so we don't end up with 404 error
messages in image files here.
|
|
|
|
|
