| Age | Commit message (Collapse) | Author |
|---|
|
|
|
target_sources() as used internally does not take alias targets.
|
|
This check fixes a probably rare case, where we land in a repository
that contains this clang-format.sh hook but where the format file went
missing. In such cases, clang-format falls back to the system defaults,
which brings undesired defaults, e.g. enforced line breaks in comments
after 90 chars, which cannot easily be reverted by a reformat.
Since clang-format's --fallback-style=none option is not available for
git clang-format, this comment reimplements the logic.
|
|
Thanks to kossebau for pointing that out.
NO_CHANGELOG
|
|
There is a chance it's going to be used in Solid, and possibly KIO.
Other exiting modules were used as templates while writing this.
|
|
CMake 3.14 ships a module with compatible variables.
|
|
- Remove deprecated version checks
- Use VERSION_GREATER_EQUAL
|
|
|
|
This relies on the apparently predominant naming pattern for those files,
those of our apps not using this often do not seem to have an appropriate
file (512x512 png) to begin with.
Explicit override is also possible, by the already existing mechanism of
putting a file with the right name into the fastlane/ source directory.
Having the icon included here will allow it to be automatically synced to
the Play store.
|
|
|
|
|
|
In case one has uninstalled the project, but has made local changes that
should be tested the test would fail. Instead check if the files exist
before adding them to the list of files that will be tested.
|
|
Instead, restore their plain text fallback output that we used to have
already prior to enabling rich text support.
|
|
|
|
pkg_search_module() is only useful when the pkgconfig file may have different names.
|
|
|
|
KF6 task: https://phabricator.kde.org/T14467
|
|
Contrary to the comment those exist (e.g. ul, ol), this just wasn't noticed
as due to the script-enforced formatting those always contain some spaces.
This resulted in different structures between English and translated
description texts. With this change all language variants show the same
structure.
|
|
|
|
We have to handle both entirely missing top-level elements and arbitrarily
incomplete sub-elements in the description body.
Until now we were just kept those gaps, resulting in missing titles or
incomplete descriptions. F-Droid didn't complain about that, but Google
Play does. This fixes e.g. Itinerary's metadata for de and ru.
|
|
|
|
|
|
This is likely still not complete, but with this at least most of
Itinerary's metadata translations are accepted during upload to the
Google Play store (the remaining ones are rejected for different reasons).
F-Droid seems considerably less picky about this, and works with either
form.
|
|
The symbol export/visibility attribute is not standardized so far and
needs to be set by language extension attribute declaration at least
with clang & MSVC, who both support that when it appears before the
standard attribute declaration.
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
NO_CHANGELOG
BUG: 436155
|
|
NO_CHANGELOG
|
|
We want to know here if the standard attribute is available
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
|
|
CMake >= 3.0 supports bracket comments, and the reStructuredText
integration code in sphinx/ext/ecm.py already supports extracting
the docs from a bracket comment instead.
Editing documentation without leading line comment markers is more simple,
e,g. when reflowing text over lines.
With ECM meanwhile requiring CMake 3.5 now it is possible to switch
(and thus follow also the approach used by cmake itself).
NO_CHANGELOG
|
|
|
|
|
|
|
|
If we tell the compiler to link the runtime statically and then explicitly link
the dynamic runtime and prohibit the static we continue to produce dynamic
builds...
|
|
That's the case when using KDE_L10N_AUTO_TRANSLATIONS, and the code handles
this case above when looking for the right po location already, but that
result was accidentally discarded here.
|
|
|
|
|
|
We need this to pass the --release option for binary factory release
builds.
An alternative approach would be to set that here automatically depending
on the CMake build type. Since that however ends up producing unsigned and
thus not immediately usable APKs (or would need a whole set of extra
arguments for proper signing) I'm not sure whether that's most convenient
for local use.
|
|
|
|
To prevent accidental use of the C++-side hex number-style version variants
on the cmake side where human-readable style is used instead (which can
happen due to the similar names of the cmake variables/arguments
and C++ macros which screws up developers' brain) we better do some
proper input checks also on the arguments EXCLUDE_DEPRECATED_BEFORE_AND_AT
and DEPRECATED_BASE_VERSION
|
|
The code argument has been deprecated in favor of public-code and
private-code options.
In general, it is highly advised to use the private-code option, but we
cannot do it because it will break the ABI.
|
|
|
|
|
|
|
|
|
|
This is a slightly modernized version of Pino's original implementation
found in KF5 and Plasma.
|
|
This matches most of the existing code in KDE; also note that Qt has the
same setting (also stating in a comment in their _clang-format that this
matching their existing code).
|
|
|
|
To prevent cmake errors with exiting usages it is checked if the target already exists.
|
