Age | Commit message (Collapse) | Author |
|
There is no need for the package to tell us its install dir.
|
|
It is redundant and obsolete.
Some frameworks can have erroneous values (eg KConfigWidgets currently
sets FooBar_LIBRARIES). Downstreams are expected to use the imported
target name instead.
CCMAIL: kde-frameworks-devel@kde.org
|
|
It is redundant and obsolete. The framework template does not set it.
|
|
|
|
|
|
These are not used anywhere.
|
|
This is a new feature in CMake 2.8.12.
|
|
As agreed.
CCMAIL: kde-frameworks-devel@kde.org
|
|
|
|
|
|
ecm_add_test was renamed eventually, but all uses weren't adapted
|
|
|
|
|
|
|
|
|
|
Every framework in KF5 has a macro similar to these, this reduces
the unnecessary duplication inside all of the frameworks
REVIEW: 112828
|
|
|
|
|
|
|
|
Accept a single version argument instead of three. The old signature
will be an error in a few days.
|
|
|
|
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Nicolás Alvarez <nicolas.alvarez@gmail.com>
REVIEW: 112912
|
|
This reverts commit 53679542f663dc74276b928e8749b082319826f4.
Since no language has been enabled, the file generated by
write_basic_package_version_file does not care about the
architecture
|
|
|
|
One of the most important things kde4_add_plugin was doing was stripping
MODULE targets from its prefix. This change makes it so those targets won't
get the prefix by default.
REVIEW: 112839
|
|
|
|
REVIEW: 112713
|
|
|
|
Both macros are obsoleted by ecm_setup_version.
REVIEW: 112665
|
|
|
|
Instead of finding all or nothing from XCB it becomes components aware.
So a user can just specify which XCB components it needs and compilation
doesn't fail if a not-needed unrelated component is not found. It also
allows to have some components as required and some as optional.
REVIEW: 112151
|
|
|
|
|
|
It approprietly sets the _FOUND variables, we were defining the all
uppercase instead.
Sorry for the mess!
CCMAIL: neundorf@kde.org
|
|
Reviewed-by: Alexander Neundorf
|
|
REVIEW: 112451
|
|
|
|
some indentations were 3 spaces, now all are 4
|
|
|
|
|
|
Add a macro for finding dependencies. It should be in a future
version of CMake. Finding dependencies is one of the major missing
pieces of KF5 Config files.
|
|
|
|
This is the old name for the setting below it. The old name was never
in a release.
|
|
|
|
Sharing compiler settings between GCC and clang does not always work: there
are flags (such as "-fno-check-new" or "-fno-reorder-blocks") that are
specific to GCC, and nothing stops these incompatibilities from becoming
bigger in the future.
Conversely, a separate clang block allows us to pass some additional flags
to clang that would have required yet another if() in the GCC block. For
now, this amounts to "-fdelayed-template-parsing".
(For KDE4, we also need -Wno-return-type-c-linkage because kdepim's
ktexteditorkabcbridge.cpp exports a function that returns a QString with C
linkage, but I hope this can be solved in a different way for kdepim5).
Last but not least, checks for bad GCC allocators or support for some flags
which are always present in clang can be avoided altogether when we know the
compiler we are using.
REVIEW: 112136
|
|
|
|
|
|
|
|
This more or less copies what was done for KDE4 in
https://git.reviewboard.kde.org/r/111612/.
With the changes applied I successfully installed a hello world
application. The linker and compiler command lines seem to be correct
and include all extended features. I also checked and debugfull also
works as expected (-g3 is added).
REVIEW: 111661
|
|
|