| Age | Commit message (Collapse) | Author |
|---|
|
kde5/services is kservices5
kde5/servicetypes is kservicestypes5
|
|
This provides versioning in a way that is simple to update for KF6, and
reduces our footprint in /usr/share.
|
|
Only frameworks should be installing in include/KF5. They use
KF5_INCLUDE_INSTALL_DIR, which has the KF5 suffix, while other code
should install to just include (or a subdirectory of their choice).
|
|
Currently, this is the same as INCLUDE_INSTALL_DIR, but
INCLUDE_INSTALL_DIR will lose the "KF5" suffix once the frameworks are
changed to use KF5_INCLUDE_INSTALL_DIR. Because INCLUDE_INSTALL_DIR is
used in INSTALL_TARGETS_DEFAULT_ARGS, there is now also a
KF5_INSTALL_TARGETS_DEFAULT_ARGS.
|
|
The ecm sphinx module occasionally tried to modify a list it was
iterating over, which is a Bad Thing and raised an exception on the
third or so time it was run without clearing the build directory.
|
|
REVIEW: 117780
|
|
cmake_policy() does not allow you to reference policies that do not yet
exist, so include a version check.
|
|
ecm_dbus_add_activation_service() requires suffient knowledge of its
internals to use that replacing two lines with one seems silly.
In order to use it you have to know it behaves like configure_file()
(because you have to construct the file yourself), except that it also
installs it somewhere (for which you have to make sure
DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is
certainly not a given for non-KDE projects). By this point, why not just
use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR
provided by KDEInstallDirs is all the magic you actually need, and if
that's explicit in the CMakeLists.txt file, it's a lot more obvious that
you should have it defined somewhere.
REVIEW: 117581
|
|
Find module tests now use find_package(), and there is a version for
when CMAKE_MODULE_PATH is set and a version for when
ecm_use_find_modules() is used.
KDE modules are also now tested.
REVIEW 117658
|
|
ECMUseFindModules allows find modules to be copied to a local directory.
These find modules may use ECMFindModuleHelpers, but they will not be in
the same relative location to ECMFindModuleHelpers.cmake and there is no
guarantee that ECMFindModulesHelpers.cmake will be in the CMake module
path.
To solve this, we make sure there is always a stub file in the same
directory as the find modules that includes the real
ECMFindModuleHelpers.cmake. The one installed with ECM just includes
"../modules/ECMFindModuleHelpers.cmake", while ecm_use_find_modules
generates a stub that uses an absolute path.
REVIEW 117658
|
|
When CMake policy CMP0048 (CMake 3.0) is set to NEW, the project()
command is meant to manage the project's version variables. We therefore
do not set the PROJECT_VERSION variables in this case.
To make sure projects do not have to specify their version in multiple
places, this also allows the keyword "PROJECT" to be passed to
ecm_setup_version instead of an actual version number. In this case, the
version passed to project() will be used.
REVIEW: 117619
|
|
This requires the icon files to be specified (which is better than
globbing, because the build system will then be able to tell when files
are added or removed and re-run CMake).
It also removes the theme name from the filename pattern: the old code
used a shorthand theme name for a small number of themes, and didn't
allow any other themes. Extending this to arbitrary themes could cause
problems with themes that have numbers or hyphens (or whatever other
delimiter character was used) in their names. Most users are likely to
just want to install to a single theme anyway (based on a random
sampling of users of kde4_install_icons), so that is what the new syntax
requires.
The old syntax still works and behaves as before.
ecm_update_iconcache is renamed to _ecm_update_iconcache - it was never
documented as public API anyway.
REVIEW: 117617
|
|
Rather than blindly using ${LIB_INSTALL_DIR} and ${INCLUDE_INSTALL_DIR}
(which assume the inclusion of KDEInstallDirs), this checks whether they
exist, also checks for ${CMAKE_INSTALL_LIBDIR} and
${CMAKE_INSTALL_INCLUDEDIR} (set by GNUInstallDirs), provides hard-coded
defaults and allows arguments to be used to override the values.
This should make it useful to projects that aren't KDE Frameworks.
REVIEW: 117593
|
|
The traditional *_LIBRARIES, *_INCLUDE_DIRS and *_DEFINITIONS do have
some uses - they make it easier to create package config files that use
found libraries in their link interface. So this makes sure these
variables are set by ecm_find_package_handle_library_components() (and
hence by FindWayland.cmake and FindXCB.cmake).
REVIEW: 117585
|
|
Imported target, version handling, package description etc.
REVIEW: 117491
|
|
This means frameworks will only depend on qttools if you have a po
directory when building them.
Approved by agateau and alexmerry on IRC.
|
|
- Always load "en" translation: This way if a plural string is not translated,
we fallback to the correct english plural form.
- Generate .ts files with correct plural settings
REVIEW: 117629
|
|
This adds an ecm-developer manual that replaces writing-find-modules.md
(a lot of which was upstreamed to CMake's own documentation). It also
adds introductory text to the ecm-*-modules manuals.
|
|
REVIEW: 117624
|
|
This allows a more straightforward way of using it, which matches the
macros that generate things like D-Bus interfaces.
REVIEW: 117475
|
|
This is the variable set by GNUInstallDirs.
REVIEW: 117596
|
|
REVIEW: 117560
|
|
|
|
- Add version handling
- Improve the docs
- mark cache variables as advanced
- make the pkg-config call actually work
REVIEW: 117490
|
|
|
|
This is deliberately modelled very closely on CMake's documentation
system. It's a hefty patch, because it involved changing all the
documentation to be in reStructuredText format. I also cleaned up the
copyright/license statements at the same time.
Note that the find modules contain the full license, due to the fact
that ecm_use_find_module() copies them out of the ECM distribution.
|
|
This causes problem with .po files whose name contains "-". A nice side
effect of this approach is we pass a QLocale to QTranslator, which means
it will try to load translations for all "ui languages" [1] instead of just
the one returned by QLocale::name().
[1]: http://doc-snapshot.qt-project.org/qt5-stable/qlocale.html#uiLanguages
REVIEW: 117296
|
|
|
|
Simplifies translation handling for frameworks using Qt translation system.
REVIEW: 117052
|
|
Always printed Wayland.
REVIEW: 117114
|
|
This currently mostly contains macros for handling components;
FindWayland and FindXCB are ported to use this module, which comes with
various improvements for them.
REVIEW: 116653
|
|
Hopefully these might be of some use in determining whether they are
still needed.
|
|
The thumbnail: ioslave from kde-runtime needs it.
Reviewed-By: Alex Merry
|
|
|
|
REVIEW: 116025
|
|
This matches what is in the main CMakeLists.txt file, and silences some
warnings in the test logs.
|
|
REVIEW: 116616
|
|
First part of the diff makes sure find_package_handle_standard_args()
gets a version number to check against.
Second part ensures we get proper results from pkg-config even if not all
components are available. find_package(Wayland COMPONENTS Client Egl)
was failing for me because I have Client installed but not Egl, causing
pkg_check_modules() to not set any PKG_Wayland_${comp} variable.
REVIEW: 116598
|
|
All of KF5 + kate + kde-workspace compile with clang and -fno-exceptions
The only problem related to clang and -fno-exceptions I could find was
http://llvm.org/bugs/show_bug.cgi?id=10910 and that is fixed since
clang version 3.0 which was released in December 2011
REVIEW: 115395
|
|
Specifically, we namespace the variables to avoid conflicts, and make
the version argument optional.
REVIEW: 116080
|
|
|
|
These are only really useful to kdoctools, so they may as well live
there.
REVIEW: 115897
|
|
* define imported targets for all components
* add version information
* print message on Windows
* add package properties
* use handle components
REVIEW: 116046
|
|
Inspired by the FindXCB module it's using components to simplify
finding just the parts which are really required.
REVIEW: 116018
|
|
This module finds the egl library through pkg-config.
REVIEW: 116014
|
|
This will be available in CMake 3.0.0. This way, we automatically pick
up any new features from it.
REVIEW: 115775
|
|
All the frameworks are ported now, so this is no longer necessary.
Checked by building everything with kdesrc-build.
|
|
Now that we no longer have to support the old syntax, some of the
more complex bits of the argument parsing can be removed.
REVIEW: 115869
|
|
Overriding a CMake package like this will just cause all sorts of
headaches later on. In this particular case, projects that depended on
CMake 2.8.13 or later (more likely 3.0.0) would fail with a message
about removing the CMakePackageConfigHelpers file, but would have no way
to do that while still using ECM.
This also renames the configure_package_config_file() macro to
ecm_configure_package_config_file(), so that anything including
CMakePackageConfigHelpers afterwards does not overwrite the macro
unexpectedly.
For now, we keep a CMakePackageConfigHelpers.cmake file that just wraps
ecm_configure_package_config_file() as configure_package_config_file()
to keep the frameworks building while they are ported.
REVIEW: 115496
Reviewed by Sune Vuorela <kde@pusling.com>
|
|
[at least everything that kdesrc-build builds. If there's something else,
then it should be added to kdesrc-build...]
|
